Skip to content

Resolve react helmet issue #5022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Oanh-and-only-Oanh opened this issue Sep 30, 2020 · 6 comments
Closed

Resolve react helmet issue #5022

Oanh-and-only-Oanh opened this issue Sep 30, 2020 · 6 comments
Assignees
@luizrrodrigues
Labels
Prod Env Environment SEO
Milestone
v1.5.1

Comments

@Oanh-and-only-Oanh
Copy link

Oanh-and-only-Oanh commented Sep 30, 2020 •
edited by luizrrodrigues
Loading

Fix community-app SEO, currently search engines getting Title and Meta before react-helmet update with respective page content. We need to make sure to run react-helmet in server side render instead client side.

Example page: https://www.topcoder.com/challenges/48406f89-3b18-488e-bccf-b7c7e6e8dd0b

SSR:
title: Topcoder

CSR:
title: QA Practice Challenge - Find Bugs on Topcoder

Lib: https://github.com/topcoder-platform/topcoder-react-utils

branches:
https://github.com/topcoder-platform/community-app/tree/seo-fix
https://github.com/topcoder-platform/topcoder-react-utils/tree/seo-fix

Challenge: https://www.topcoder.com/challenges/78711bc1-13ad-450c-ab01-18a799b6a0a2
@luizrrodrigues
Copy link
Collaborator

#4836

@Oanh-and-only-Oanh Oanh-and-only-Oanh mentioned this issue Sep 30, 2020
Closed
luizrrodrigues added a commit that referenced this issue Oct 14, 2020
@luizrrodrigues
ci: deploy seo-fix to Stag env
b9e2811 
Issue #5022
@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues ,

  1. Still see topcoder in title but for a shorter time. See video
    seo.mov.zip

@luizrrodrigues
Copy link
Collaborator

@SathyaJayabal Can we track this in new issue, this happen because currently logical add a default meta to side in client side (this not affect Google engine to get meta info)

@SathyaJayabal
Copy link
Collaborator

@luizrrodrigues ok

@luizrrodrigues luizrrodrigues added this to the Release by 11/3/2020 milestone Nov 2, 2020
@luizrrodrigues luizrrodrigues mentioned this issue Nov 3, 2020
Merged
@SathyaJayabal
Copy link
Collaborator

verified on staging (develop)
seo.mov.zip

@SathyaJayabal SathyaJayabal added Prod Env Environment and removed QA Pass in Staging labels Nov 3, 2020
@SathyaJayabal
Copy link
Collaborator

verified on prod
seo_prod.mov.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luizrrodrigues luizrrodrigues

Labels
Prod Env Environment SEO
Projects
None yet
Milestone
v1.5.1
Development

No branches or pull requests
3 participants
@luizrrodrigues @Oanh-and-only-Oanh @SathyaJayabal