You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Changes broke some unit tests (as a rapid solution those test are skipped for now).Unit tests will be taken care of separately
- URLs 'bases' should not be hardcoded. You should use the configured ones.
- /src/shared/components/Dashboard/SubtrackStats/index.jsx:L(29, 33, 36, 39) you should configure the returned values and not use magic-numbers
- You should reuse the configured variables for colors in your scss instead of hardcoding the colors.Not good, but as long as it already matches the design no need to touch it right now
Spec mentions 'You should check challengeListing.pendingRequest path to see when all your requests to load challenges are completed.'
You are not using this flag
Spec mentions 'There is challengeListing.oldestData field intended to deal with it. If upon entering the Dashboard you see that this field is too far into the past, you better drop and reload all challenges loaded into Redux state. '
You are not using oldestData param at allFixed
Spec mentions 'If upon entering the Dashboard you see that this field is too far into the past, you better drop and reload all challenges loaded into Redux state. Sure, the actual time which triggers this should be exposed via App configuration.'
There is no such configurable field
Remaining issues were included into another dashboard challenge, and if there are still some problems, they should be logged another time in a fresher ticket with review feedbacks
- The way you display the cards (float on the right side) looks ugly http://take.ms/h4viU
Similarly, position of challenge looks odd when there is one challenge matching the filter - https://cl.ly/3Z0p0P3Z1j2h
It's too close to the filter and there are empty space on the other side
Uh oh!
There was an error while loading. Please reload this page.
Remaining issues were included into another dashboard challenge, and if there are still some problems, they should be logged another time in a fresher ticket with review feedbacks
The text was updated successfully, but these errors were encountered: