-
Notifications
You must be signed in to change notification settings - Fork 56
Improve process of running tests locally #261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If we can do it without publishing the custom image to dockerhub, we should be good to go with this. |
On the second thoughts I decided to go with the first way, as it looks like more comfortable in many ways:
The PR #263 is raised. |
This is already in DEV, so I'm closing it. |
Ups, it was in DEV only in my dreams. I've fixed tests in PR so it can be reviewed and merged now #265. |
FYI, has been merged to DEV and I guess to PROD and works well during local development. So this issue may be closed. |
So far to run tests locally during development process we should rebuild and restart the Docker which makes it hard to run tests during development. And if after we want to continue developing we have to it again to switch back to the main DB, and we will also lose any data in our DB. This makes running test during development very time-consuming.
I'm thinking to ask the community to fix this and let us run tests without the necessity of rebuilding the Docker containers by simply running
npm run test
.I see two ways to accomplish it:
The simple way would be to add one more instance of postgres in docker-compose but we will have two instances running which is not that good.
The better way would be to use one instance but create two DBs
projectsdb
andprojectsdb_test
. Unfortunately, standard postgres image doesn't support creating several DBs so probably we will have to create a custom image with such support for example, as mentioned in this issue.@vikasrohit what do you think?
The text was updated successfully, but these errors were encountered: