Copilots with "requested" invite can see projects in the list

[maxceem]

Actual behavior

When we request an invitation for a copilot to the Topcoder Team they can see the project listed.

Expected behavior

When we request an invitation for a copilot to the Topcoder Team they shouldn't see such a project listed until they have the invite request accepted.

How to reproduce:

1. Invite pshah_copilot using pshah_manager to any project as copilot (using Topcoder Team dialog).

   

2. As pshah_manager doesn't have "Copilot Management" permission, pshah_copilot wouldn't be added to the project but his invite would be requested and waiting for any Copilot Manager to "accept" it. Don't accept it.

3. Now log in with pshah_copilot and you would see the project where copilot has "requested" invite listed on the project listing page:

   

4. At the same time if Copilot would try to open such a project, they would get error 404, as expected, because copilot is not a member.

This is an existent issue in V4 which has been also migrated to V5.

@vikasrohit, could you please confirm that it's a valid issue and the actual behavior is not desired.

[vikasrohit]

Agreed. we need to fix it before the release. It is a bug.

[vikasrohit]

It is fixed, @maxceem ?

[maxceem]

Fixed in DB request, but not in ES. I will take care of it asap via F2F.

[maxceem]

Run F2F for this https://www.topcoder.com/challenges/30111699

[maxceem]

Got the solution from F2F. @vikasrohit would like me to create a HOTFIX or just merge it to dev?

[vikasrohit]

Hotfix is good as we have sufficient time in this week to monitor. Hope the changes are not big, I mean the probability of any regression is very less.

[maxceem]

@vikasrohit there are hotfixes:
PROD #433
DEV #434

[vikasrohit]

@maxceem merged the dev version first, please let me know it works for you in dev (once the build is complete).

[maxceem]

@vikasrohit Works well for me on DEV.

[vikasrohit]

Deployed to the production.

[lakshmiathreya]

@vikasrohit is 2.0.0 the correct milestone? Also, am unable to edit this Issue ... would like to verify and close it ...

[lakshmiathreya]

cc @nithyaasworld

[vikasrohit]

@vikasrohit is 2.0.0 the correct milestone? Also, am unable to edit this Issue ... would like to verify and close it ...

I am not sure but I usually include the hotfixes in the upcoming milestone because until recently github didn't allow to include an issue in closed milestone. However, now as it allows us to include the issues in closed milestones, I am thinking of including such hotfixes in last closed milestone. fyi, release for the hotfix is https://github.com/topcoder-platform/tc-project-service/releases/tag/2.0.0.1

[lakshmiathreya]

Milestone is 2.0.0.1 for this hotfix in that case. We referred to the v5 release as 2.5 earlier. It should have been 2.0.0?

…

On Tue, Dec 24, 2019 at 5:47 PM vikasrohit ***@***.***> wrote: @vikasrohit <https://github.com/vikasrohit> is 2.0.0 the correct milestone? Also, am unable to edit this Issue ... would like to verify and close it ... I am not sure but I usually include the hotfixes in the upcoming milestone because until recently github didn't allow to include an issue in closed milestone. However, now as it allows us to include the issues in closed milestones, I am thinking of including such hotfixes in last closed milestone. fyi, release for the hotfix is https://github.com/topcoder-platform/tc-project-service/releases/tag/2.0.0.1 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#419?email_source=notifications&email_token=AMKWEMVOZYVN5KAU6FBNXQ3Q2H4W5A5CNFSM4JZYJKR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHTD4WY#issuecomment-568737371>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AMKWEMS3YBVAPOMJYXC53FTQ2H4W5ANCNFSM4JZYJKRQ> .

[vikasrohit]

Creating milestone for a hotfix seems overkill to me, that is why we don't create milestones for them. However, as it is a new release I appended .1 to the previous release 2.0.0. I think we can keep hotfixes in previously closed milestone and tag a separate release.

[maxceem]

Fix for this issue has been pushed to PROD as a HOTFIX and might be closed.