Syncing master with v5 changes #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added missing CRUD endpoints for attachments and project members - removed usage of direct API in favour of a separate "legacy-project-processor" - removed DB endpoints for projects, phases and phaseProducts Excluded files: - package.json (changed repo) - .circleci/config.yml (build specific in another repo)
…tSettings, projectReports)
Merge changes from 'dev' branch
…n data from header
…acters Some query params may have special characters thus got encoded client-side. So I'm reverting code which uses "decodeURIComponent" to decode such query params. TODO: we might replace custom logic for decoding **some** query params with an automatic mechanism to decode **all** query params.
…base bypassing ElasticSearch.
- filter orgConfigs data from ES - add unit tests for the changes
Get Timeline from DB query param
Filter orgConfigs
Merged swagger file
Merged postman file
- removed legacy DB endpoints - removed degenerated cases for checking body without "param" - added request to get a timeline by id from DB
- bring back firing Kafka events for Notification Service - bring back unit tests for these events - added some new unit tests for events - fixed and improved some unit tests for events in "v5-upgrade" and "dev"
ElasticSearch by default refreshes indexes at a interval of 1 second. There are chances that some newly added or updated documents are not available during test and some deleted documents still exist for a while, which results in random test failures. The solution contains two parts: 1. refresh the indices before making get/search requests to ES server to make sure that all ES data are visible. 2. Before some of the test cases, clear all ES data created by the previous test cases.
fix: fix unit tests so they don’t fail randomly.
- fixed response format and removed "ResponseMetadata" definition
- send "original" in PROJECT_UPDATED event as it's required for generating BUS API events
- as now all the data is stored in ES, to keep this test work we have to clean ES, so the data is retrieved from DB as unit test only prepare data in DB for testing
Easy Local Setup of Project Service with Connect App using docker-compose.
# Conflicts: # package.json # src/models/project.js # src/permissions/index.js # src/routes/index.js # src/routes/projectMemberInvites/create.js # src/routes/projectMemberInvites/get.js # src/routes/projectMemberInvites/update.js # src/routes/projectMembers/get.js # src/routes/projectMembers/list.js # src/routes/projects/get.js # src/routes/projects/list-db.js # src/routes/projects/list.js # src/util.js
# Conflicts: # src/routes/projectMemberInvites/create.js
This reverts commit 1c24d2a.
fix project data in DB for ES
# Conflicts: # src/routes/projectMembers/update.js
This issues happened during merging dev into v5
- it should return all the projects, not only the one with invites - invites should be returned not only "pending", but also "requested"
Without this fix, endpoints for getting a list of members and invites, return only 3 records.
use correct Kafka event names
Updated circleci config to deploy to new v5 cluster from now on from tc-project-service instead of projects-api. We want to keep the tc-project-service as main repo for future work because we don't want to loose the history of the api. We would deprecate the projects-api repo very soon.
Syncing V5 changes into new develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would trigger the production build.