fix(PM-1168): invite user when assigning as copilot #809

hentrymartin · 2025-05-19T18:00:43Z

What's in this PR?

invite user when assigning as copilot

Ticket link - https://topcoder.atlassian.net/browse/PM-1168

.circleci/config.yml

src/routes/copilotOpportunity/assign.js

github-actions · 2025-05-19T18:01:12Z

src/routes/copilotOpportunity/assign.js

+        RESOURCES.PROJECT_MEMBER_INVITE,
+        invite.toJSON());
+
+      const initiator = await util.getMemberDetailsByUserIds([req.authUser.userId], req.log, req.id);


Check if util.getMemberDetailsByUserIds can return an empty result or error, and handle such cases to avoid potential runtime errors.

src/routes/copilotOpportunity/assign.js

github-actions · 2025-05-19T21:32:59Z

src/routes/copilotOpportunity/assign.js

+        email: existingUser.email,
+      })
+
+      console.log("aftr create", invite)


Remove the console.log statement before merging the code. Debugging statements should not be present in production code.

github-actions · 2025-05-19T21:33:02Z

src/routes/copilotOpportunity/assign.js

+            ],
+          }],
+        },
+        recipients: [existingUser.email],


The change from invite.email to existingUser.email suggests that the email recipient is now being set to an existing user's email. Ensure that existingUser is properly defined and initialized before this line to avoid potential runtime errors.

github-actions · 2025-05-20T15:04:49Z

src/routes/copilotOpportunity/assign.js

+        },
+      });
+
+      req.log.info("before create", existingUser)


Consider removing or modifying the log statement req.log.info("before create", existingUser) if it is not necessary for production. Logging sensitive information or excessive logging can lead to performance issues and security concerns.

github-actions · 2025-05-20T15:04:52Z

src/routes/copilotOpportunity/assign.js

+        email: existingUser.email,
+      })
+
+      req.log.info("aftr create", invite)


Consider correcting the typo in the log message from "aftr create" to "after create" for better readability and consistency.

github-actions · 2025-05-20T15:12:29Z

src/routes/copilotOpportunity/assign.js

+        },
+      });
+
+      const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id)[0];


It seems like util.getMemberDetailsByUserIds([userId], req.log, req.id) returns a promise, but the code attempts to access the first element directly without awaiting the promise. Consider using await to ensure applicationUser is correctly assigned.

github-actions · 2025-05-20T15:12:30Z

src/routes/copilotOpportunity/assign.js

+        email: applicationUser.email,
+      })
+
+      req.log.info("aftr create", invite)


Typo in log message: 'aftr' should be corrected to 'after'.

github-actions · 2025-05-20T15:12:32Z

src/routes/copilotOpportunity/assign.js

+            ],
+          }],
+        },
+        recipients: [applicationUser.email],


It seems like the recipient email has been changed from existingUser.email to applicationUser.email. Ensure that applicationUser is correctly defined and initialized before this line, and that it contains the expected email address for the invitation process.

src/routes/copilotOpportunity/assign.js

github-actions · 2025-05-20T16:34:23Z

src/routes/copilotOpportunity/assign.js

+
+      const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id);
+
+      req.log.info("before create", applicationUser, userId)


Consider verifying if userId is necessary in the log statement. If applicationUser already contains relevant information about the user, logging userId might be redundant.

src/routes/copilotOpportunity/assign.js

github-actions · 2025-05-20T18:09:32Z

src/routes/copilotOpportunity/assign.js

+
+      const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id);
+
+      req.log.info("before create", applicationUser, userId, applicationUser[0].email)


Ensure that applicationUser[0] is not undefined before accessing .email to prevent potential runtime errors. Consider adding a check to verify that applicationUser[0] exists.

src/routes/copilotOpportunity/assign.js

kkartunov

We should handle only of the invitation is accepted by the copilot. As currently implemented this directly accepts and modifies records which should be done only after invitation is accepted.

github-actions · 2025-05-21T21:21:34Z

migrations/umzug/migrations/20250521211708-copilot_invite_from_application.js

@@ -0,0 +1,18 @@
+module.exports = {
+  up: async (queryInterface, Sequelize) => {
+    await queryInterface.addColumn('project_member_invites', 'applicationId', {


Consider specifying an index on the applicationId column for improved query performance, especially if this column will be frequently used in WHERE clauses or joins.

github-actions · 2025-05-21T21:21:37Z

src/routes/copilotOpportunity/assign.js

+        },
+      });
+
+      if (existingInvite) {


The findAll method returns an array, so existingInvite will always be truthy even if it's empty. Consider using findOne if you expect a single result, or check if existingInvite.length > 0.

github-actions · 2025-05-21T21:21:37Z

src/routes/copilotOpportunity/assign.js

+      });
+
+      if (existingInvite) {
+        const err = new Error(`User already has an pending invite to the project`);


The error message contains a grammatical error. It should be 'a pending invite' instead of 'an pending invite'.

github-actions · 2025-05-21T21:21:40Z

src/routes/copilotOpportunity/assign.js

+                title: config.get('inviteEmailSectionTitle'),
+                projectName: project.name,
+                projectId,
+                initiator: authUserDetails[0],


The removal of the code block that updates the status of CopilotRequest, opportunity, and CopilotApplication might lead to inconsistencies in the database. Ensure that these status updates are handled elsewhere if they are still necessary for the application's logic.

github-actions · 2025-05-21T21:21:43Z

src/routes/projectMemberInvites/update.js

@@ -119,7 +119,9 @@ module.exports = [
                  };
                  return util
                    .addUserToProject(req, member)
-                    .then(() => res.json(util.postProcessInvites('$.email', updatedInvite, req)))
+                    .then(async () => {


The use of async in the then block seems unnecessary here since there is no await expression inside the block. Consider removing async to simplify the code.

github-actions · 2025-05-21T22:13:30Z

src/models/projectMember.js

@@ -44,11 +44,12 @@ module.exports = function defineProjectMember(sequelize, DataTypes) {
  })
    .then(res => _.without(_.map(res, 'projectId'), null));

-  ProjectMember.getActiveProjectMembers = projectId => ProjectMember.findAll({
+  ProjectMember.getActiveProjectMembers = (projectId, t) => ProjectMember.findAll({


Consider adding a default value for the transaction parameter t to ensure backward compatibility if the function is called without this argument.

github-actions · 2025-05-21T22:13:34Z

src/models/projectMemberInvite.js

@@ -13,6 +13,16 @@ module.exports = function defineProjectMemberInvite(sequelize, DataTypes) {
        isEmail: true,
      },
    },
+    applicationId: {
+      type: DataTypes.BIGINT,
+      allowNull: true,


Consider adding a validation to ensure applicationId is a positive integer if it is not null. This can help prevent invalid data from being stored in the database.

github-actions · 2025-05-21T22:13:34Z

src/models/projectMemberInvite.js

+        key: 'id',
+      },
+      onUpdate: 'CASCADE',
+      onDelete: 'CASCADE',


Ensure that the onDelete: 'CASCADE' behavior aligns with the intended data integrity rules. This setting will automatically delete the invite if the associated copilot application is deleted, which may not always be desirable.

github-actions · 2025-05-21T22:13:38Z

src/routes/copilotOpportunity/assign.js

+        where: {
+          id: projectId,
+        },
+        transaction: t,


Ensure that the transaction t is properly initialized and managed. If t is not defined or handled correctly, it could lead to issues with database operations.

github-actions · 2025-05-21T22:13:41Z

src/routes/copilotOpportunity/assign.js

+          role: PROJECT_MEMBER_ROLE.COPILOT,
+          status: INVITE_STATUS.PENDING,
+        },
+        transaction: t,


The addition of transaction: t seems to be intended for ensuring that the invite creation is part of a transaction. Ensure that t is a valid transaction object and is correctly managed (e.g., committed or rolled back) in the surrounding code to prevent potential issues with database consistency.

github-actions · 2025-05-21T22:13:47Z

src/routes/projectMemberInvites/update.js

@@ -94,7 +94,7 @@ module.exports = [
            if (updatedInvite.status === INVITE_STATUS.ACCEPTED ||
              updatedInvite.status === INVITE_STATUS.REQUEST_APPROVED) {
              return models.ProjectMember.getActiveProjectMembers(projectId)
-                .then((members) => {
+                .then(async (members) => {


Using async in a .then() callback can be confusing and is generally not recommended. Consider refactoring the code to use async/await throughout for better readability and consistency.

github-actions · 2025-05-21T22:13:52Z

src/routes/projectMemberInvites/update.js

-                    .addUserToProject(req, member)
-                    .then(() => res.json(util.postProcessInvites('$.email', updatedInvite, req)))
-                    .catch(err => next(err));
+                  const t = await models.sequelize.transaction();


Consider adding error handling for the transaction creation to ensure that any issues during transaction initialization are caught and handled appropriately.

github-actions · 2025-05-21T22:13:52Z

src/routes/projectMemberInvites/update.js

+                  const t = await models.sequelize.transaction();
+                  try {
+                    await util.addUserToProject(req, member, t);
+                    if (invite.applicationId) {


The invite.applicationId check assumes that invite is always defined. Consider adding a check to ensure invite is not null or undefined before accessing its properties to prevent potential runtime errors.

github-actions · 2025-05-21T22:13:52Z

src/routes/projectMemberInvites/update.js

+                  try {
+                    await util.addUserToProject(req, member, t);
+                    if (invite.applicationId) {
+                      const application = await models.CopilotApplication.findOne({


The findOne operation on CopilotApplication does not handle the case where no application is found. Consider adding a check to handle the scenario where application is null, which could prevent potential errors when attempting to update a non-existent record.

github-actions · 2025-05-21T22:13:52Z

src/routes/projectMemberInvites/update.js

+                        transaction: t
+                      });
+
+                      const opportunity = await models.CopilotOpportunity.findOne({


Similar to the previous comment, ensure that the findOne operation on CopilotOpportunity handles the case where no opportunity is found. This will prevent errors when trying to update a null object.

github-actions · 2025-05-21T22:13:53Z

src/routes/projectMemberInvites/update.js

+                        transaction: t,
+                      });
+
+                      const request = await models.CopilotRequest.findOne({


Ensure that the findOne operation on CopilotRequest handles the case where no request is found. This will prevent errors when trying to update a null object.

kkartunov

Looks good.

fix: invite user when assigning as copilot

69eb97a

github-actions bot reviewed May 19, 2025

View reviewed changes

.circleci/config.yml Show resolved Hide resolved

github-actions bot reviewed May 19, 2025

View reviewed changes

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

github-actions bot reviewed May 19, 2025

View reviewed changes

fix: invite user when assigning as copilot

675858b

github-actions bot reviewed May 19, 2025

View reviewed changes

fix: invite user when assigning as copilot

613defe

github-actions bot reviewed May 20, 2025

View reviewed changes

fix: invite user when assigning as copilot

e3303fe

github-actions bot reviewed May 20, 2025

View reviewed changes

fix: invite user when assigning as copilot

d83097b

github-actions bot reviewed May 20, 2025

View reviewed changes

fix: invite user when assigning as copilot

68fdf7b

github-actions bot reviewed May 20, 2025

View reviewed changes

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

github-actions bot reviewed May 20, 2025

View reviewed changes

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

fix: invite user when assigning as copilot

7383c70

github-actions bot reviewed May 20, 2025

View reviewed changes

fix: invite user when assigning as copilot

aaea12c

github-actions bot reviewed May 20, 2025

View reviewed changes

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

github-actions bot reviewed May 20, 2025

View reviewed changes

src/routes/copilotOpportunity/assign.js Show resolved Hide resolved

fix: removed circle config

35d27e0

hentrymartin requested a review from kkartunov May 21, 2025 13:14

kkartunov requested changes May 21, 2025

View reviewed changes

fix: added migration to set application id in project member invite

1102fdc

github-actions bot reviewed May 21, 2025

View reviewed changes

hentrymartin added 2 commits May 21, 2025 23:24

fix: added migration to set application id in project member invite

fe085cf

fix: complete the copilot application on accepting invite

42485c5

github-actions bot reviewed May 21, 2025

View reviewed changes

kkartunov approved these changes May 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(PM-1168): invite user when assigning as copilot #809

fix(PM-1168): invite user when assigning as copilot #809

hentrymartin commented May 19, 2025

github-actions bot May 19, 2025

github-actions bot May 19, 2025

github-actions bot May 19, 2025

github-actions bot May 20, 2025

github-actions bot May 20, 2025

github-actions bot May 20, 2025

github-actions bot May 20, 2025

github-actions bot May 20, 2025

github-actions bot May 20, 2025

github-actions bot May 20, 2025

kkartunov left a comment

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

github-actions bot May 21, 2025

kkartunov left a comment


		const applicationUser = await util.getMemberDetailsByUserIds([userId], req.log, req.id);

		req.log.info("before create", applicationUser, userId)

fix(PM-1168): invite user when assigning as copilot #809

Are you sure you want to change the base?

fix(PM-1168): invite user when assigning as copilot #809

Conversation

hentrymartin commented May 19, 2025

What's in this PR?

github-actions bot May 19, 2025

Choose a reason for hiding this comment

github-actions bot May 19, 2025

Choose a reason for hiding this comment

github-actions bot May 19, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

github-actions bot May 20, 2025

Choose a reason for hiding this comment

kkartunov left a comment

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

github-actions bot May 21, 2025

Choose a reason for hiding this comment

kkartunov left a comment

Choose a reason for hiding this comment