fix: pin Neo4j Docker image to 5.26 in docker-compose.yml#2323
fix: pin Neo4j Docker image to 5.26 in docker-compose.yml#2323Vasilije1990 merged 1 commit intotopoteretes:devfrom
Conversation
Replace neo4j:latest with neo4j:5.26 for reproducible builds. The project's neo4j Python driver requirement (>=5.28,<6) confirms Neo4j 5.x compatibility. Fixes topoteretes#2302
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
docker-compose.yml (2)
158-158: Consider pinningredisinsightfor consistency.For the same reproducibility reasons that motivated pinning Neo4j, you may want to pin
redislabs/redisinsight:latestto a specific version in a follow-up. This is outside the scope of the current fix but worth noting for consistency.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docker-compose.yml` at line 158, The docker-compose entry uses an unpinned image "image: redislabs/redisinsight:latest" which hurts reproducibility; change that value to a specific, immutable RedisInsight tag (for example replace ":latest" with a concrete version like ":v2.2.0" or the project's chosen release) so the service always pulls the same image; update the "image: redislabs/redisinsight:latest" line in the docker-compose service definition (the image key) to the chosen version tag and document the selected tag in the PR description.
94-94: Good change, with a minor improvement suggestion for reproducibility.Pinning the Neo4j image to
5.26is a solid improvement overlatest. The Python driver5.28+is fully compatible with Neo4j 5.26 (LTS), which was released December 6, 2024.For even stronger reproducibility, consider pinning to a specific patch version like
neo4j:5.26.21instead of the moving5.26tag, which may resolve to different patch versions over time (e.g., 5.26.22 in the future).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@docker-compose.yml` at line 94, Update the Docker image tag in docker-compose.yml to pin a specific patch release instead of the moving minor tag: replace the image value currently set via "neo4j:5.26" with a concrete patch tag such as "neo4j:5.26.21" so the Neo4j service (image: neo4j) resolves to a fixed patch version for reproducible environments.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@docker-compose.yml`:
- Line 158: The docker-compose entry uses an unpinned image "image:
redislabs/redisinsight:latest" which hurts reproducibility; change that value to
a specific, immutable RedisInsight tag (for example replace ":latest" with a
concrete version like ":v2.2.0" or the project's chosen release) so the service
always pulls the same image; update the "image: redislabs/redisinsight:latest"
line in the docker-compose service definition (the image key) to the chosen
version tag and document the selected tag in the PR description.
- Line 94: Update the Docker image tag in docker-compose.yml to pin a specific
patch release instead of the moving minor tag: replace the image value currently
set via "neo4j:5.26" with a concrete patch tag such as "neo4j:5.26.21" so the
Neo4j service (image: neo4j) resolves to a fixed patch version for reproducible
environments.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: de33c7fc-af9f-4e07-a16d-2bc66adc1a12
📒 Files selected for processing (1)
docker-compose.yml
Description
Replace
neo4j:latestwithneo4j:5.26indocker-compose.ymlfor reproducible builds. Using:latestcan break builds without warning when a new major version is released. The project requiresneo4j>=5.28.0,<6for the Python driver, confirming Neo4j 5.x compatibility.Fixes #2302
Acceptance Criteria
neo4j:latestreplaced with pinned versionneo4j:5.26Type of Change
Screenshots
N/A
Pre-submission Checklist
DCO Affirmation
I affirm that all code in every commit of this pull request conforms to the terms of the Topoteretes Developer Certificate of Origin.
Summary by CodeRabbit