Skip to content

Handle curses.tigetstr() returning None #3094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2022
Merged

Handle curses.tigetstr() returning None #3094

merged 1 commit into from
Jan 28, 2022

Conversation

JelleZijlstra
Copy link
Contributor

bdarnell
bdarnell approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It could be a bit more concise by folloiwng the pattern from line 145 (self._normal = unicode_type(curses.tigetstr("sgr0") or "", "ascii") but this way is fine too.

@bdarnell bdarnell merged commit 2c04548 into tornadoweb:master Jan 28, 2022
@JelleZijlstra JelleZijlstra deleted the patch-1 branch January 28, 2022 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdarnell bdarnell bdarnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelleZijlstra @bdarnell