Fix deadlock with --parallel and lots of output #1202
Conversation
| @@ -1,13 +1,23 @@ | |||
| import os | |||
| import subprocess | |||
| import sys | |||
| import tempfile | |||
There was a problem hiding this comment.
I believe this is already implemented partially within Action, we just need to make this an Action and perhaps have a flag allowing this👍
There was a problem hiding this comment.
this is way way simpler than involving Action
There was a problem hiding this comment.
I know it's simpler but not using the Action is a bug, as generally, that's what we should use. That was added especially for such use cases, and somewhere we even have an issue to make this content available as a file afterwards (for CIs); so that's the right solution to solve both at the same time.
There was a problem hiding this comment.
that seems orthogonal and existing :P
There was a problem hiding this comment.
not really orthogonal given in sense that the buffer overload is what is breaking here things, and would we write to file that would not exist 🤔
There was a problem hiding this comment.
it's not that simple, no -- tox -p is implemented by running sub process which invoke python -m tox: https://github.com/tox-dev/tox/pull/1202/files#diff-7f1e93c77a2f9f1b1f2c01a8950bad0dR25
There was a problem hiding this comment.
I know, I did it, bur action also uses underneath subprocess via popen.
There was a problem hiding this comment.
Anyways we can go ahead just mind you we'll need it switch at some point. Thought if not too hard we could do it now. If you find it non trivial we can hold for now.
There was a problem hiding this comment.
my initial try ended in a different deadlock due to the log files, I'd rather not
There was a problem hiding this comment.
let's come back to this later then 👍
Resolves #1183