Skip to content

Widen Enzyme compat to avoid transitive dependency conflict #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Widen Enzyme compat to avoid transitive dependency conflict #27

merged 2 commits into from
Apr 16, 2024

Conversation

rubenseyer
Copy link
Contributor

The recent 0.12 release of Enzyme caused a conflict for me with Turing, which is resolved by annoyingly downgrading this package until there are no more compat bounds.
The tests pass for me with version 0.12, so hopefully it is safe to allow it as well.

Copy link
Collaborator

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me if tests pass. Unfortunately, CompatHelper does not support weak dependencies yet. Can you bump the version number as well (to 1.8.0)?

@devmotion devmotion merged commit 4fa0c7d into tpapp:master Apr 16, 2024
@devmotion
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants