-
Notifications
You must be signed in to change notification settings - Fork 38
fix: whereNotLike misses the not in the sql query #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tpetry i went ahead and also added the "fallback" to the available implementation of laravel if we are on laravel 11.17.0 and above |
Can you explain the fallback you've added? So why you've added that? Because the executed SQL queries should really not be different when a different Laravel version is used. |
@tpetry laravel/framework is using the "->whereBasic" call for the Postgres grammer which is wrapping the column in a The "fallback" i added is just using the implementation of laravel itself instead of overriding it. I don't get why the package would override the behaviour when laravel supports it out of the box since 11.17.0. I can revert the commit 4e64ea3 if you want but I'd think it would be better to use the laravel implementation instead of overriding the behaviour. |
I've added the Please remove the version check and change my implementation to be identical to Laravel's one 😉 |
4f93f76
to
ff9b257
Compare
Thanks for writing the fix. And sorry for the inconvenience. |
At the moment when calling
whereNotLike
ororWhereNotLike
the query is missing the 'not' in the query. This is actually super critical.Is there a plan to implement something to only apply the
where*Like
queries of this package if you use laravel/framework < 11.19.0 ? in order to use the "real" implementation of laravel itself