-
Notifications
You must be signed in to change notification settings - Fork 3
feat: migrate to Vue 3 Composition API #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+9,944
−12,410
Merged
Changes from all commits
Commits
Show all changes
91 commits
Select commit
Hold shift + click to select a range
0a666b2
refactor: migrate to Vue 3 and Vite, and fix lint errors
reiroop 6402d99
fix(client): resolve UI layout issues and Docker environment for Vue …
reiroop 939d8f4
chore(client): setup static analysis and testing environment
reiroop 5ee68d0
fix(client): resolve type errors and configure static analysis
reiroop 25385fe
chore(client): setup typescript and pinia
reiroop dc79793
fix: resolve all typescript type errors and migrate components to TS
reiroop a8d5609
feat: migrate userList, applicationList, and applicationDetail stores…
reiroop 6cd3347
refactor: migrate to Composition API and fix lint errors
reiroop f872de9
fix: resolve type error in NewApplicationPage
reiroop 47df6a5
refactor: migrate remaining js files to ts
reiroop 02c8c35
chore: remove vuex and migrate test/config files to ts
reiroop 036a67a
style: fix sass deprecation warnings by migrating to @use
reiroop 7d235f2
fix: resolve build warnings (sass deprecation and const assignment)
reiroop a48485e
refactor: fix build warnings and migrate to ESM
reiroop 88eff73
perf: optimize vite chunk size and refactor AdminPage
reiroop ead57e8
perf: implement dynamic imports for routes
reiroop 38842d0
chore: update test script to use vitest run
reiroop 710152c
perf: enable vuetify tree-shaking
reiroop 0f5a6b4
test: add unit tests for utility functions
reiroop 9a8ffc0
fix: resolve type error in api.test.ts
reiroop 53ab543
docs: update documentation for vue3/vite migration
reiroop 9cc404c
chore: update dependencies and cleanup config
reiroop 1e99463
test: implement component and E2E tests
reiroop f96a28a
test: enhance test coverage with component and E2E tests
reiroop 8ac8054
refactor: enable noImplicitAny and fix core type errors
reiroop 22ecf21
refactor: fix type errors in stores and consuming components
reiroop cefbe6c
test: fix type errors in unit tests
reiroop 1747083
refactor: convert remaining Vue components to TypeScript
reiroop 5ede358
refactor: migrate remaining components to Composition API
reiroop cf1d4d1
refactor: split tsconfig into app and node configs
reiroop 14c90d0
docs: update client readme for vite and e2e commands
reiroop 7ba3548
fix: rename template ref to avoid collision with v-model in NewApplic…
reiroop fa43e39
fix: resolve NewApplicationPage ref collision, improve tests, and fix…
reiroop bd3d901
test: add coverage tool and improve NewApplicationPage tests
reiroop 7e45878
chore: ignore coverage directory
reiroop 3ff1526
test: increase playwright timeout for firefox
reiroop 6c6ff05
feat: improve error handling and tests for application pages
reiroop 460e4e3
fix: increase e2e test timeout and update docs
reiroop 0eeb243
test: add unit tests for stores/components and fix e2e firefox timeout
reiroop 1eb6e60
test: fix e2e race condition and remove duplicate vuetify setup in un…
reiroop 9a908fa
refactor: improve type safety by removing any and using shared types
reiroop 8cb3349
fix(e2e): resolve firefox timeouts and visibility issues
reiroop b2df785
docs: update README with new tech stack and remove resolved TODOs
reiroop 96b95db
fix: 申請差し戻しモーダルのバグ修正とFirefox E2Eテストの安定化
reiroop 577cf0c
chore: remove commented out code in test
reiroop 1269c29
refactor: improve E2E test stability and use absolute API paths
reiroop 5cc04e4
chore: update CI and dependencies
reiroop b93541a
chore: update CI workflow to include test job
reiroop d866ec6
chore: update node version to 22.x
reiroop f188a5f
chore: update CI workflow to use node-version 22.x
reiroop 402d2d2
chore: update package-lock.json
reiroop f312f49
fix: resolve E2E test failure in ApplicationListPage
reiroop 0d4064d
fix: disable animations for Firefox in admin-page E2E tests
reiroop b28cca3
ci: add type-check job to client workflow
reiroop eda0400
refactor(client): use vitest/config in vite.config.ts
reiroop ca9de12
refactor(client): use imported utility functions directly in template
reiroop 7de7be4
fix: restore sources to Taskfile for hot-reload
reiroop 41b8a17
Refactor: Move application state update logic to Pinia store
reiroop 879e9b5
Refactor: Use Vuetify v-btn in SimpleButton component
reiroop 505a6b0
fix(client): resolve style conflicts with Vuetify 3
reiroop 828666b
fix(client): correct theme color application and style variables
reiroop b49f211
test(e2e): fix flaky test in create-application.spec.ts
reiroop 3a2f15a
ci: prevent duplicate workflow runs
reiroop 04d5833
fix(client): improve UI visibility and layout for application details
reiroop d5314b1
fix(client): correct timeline structure and improve chip visibility
reiroop a689194
fix(client): refine UI styling for logs, chips, and buttons
reiroop ea88b36
fix(client): correct color semantics, log spacing, and button visibility
reiroop 0654555
fix(client): resolve UI usability issues and refine styles
reiroop 09aca0b
fix(client): resolve timeline spacing and autocomplete interaction is…
reiroop 8c98a27
fix(client): resolve log layout stretching and dialog dropdown issues
reiroop e2fda01
fix(client): restore timeline lines and fix user selection in dialog
reiroop cc36dd9
fix(client): restore timeline connectivity and simplify date selection
reiroop 8cbbbea
fix(client): resolve component ref conflict and force timeline styling
reiroop f4e7761
fix(client): force display of timeline vertical lines via CSS
reiroop 031660f
fix(client): remove 'align=top' to restore timeline vertical lines
reiroop 76c288f
test: update e2e and unit tests for improved stability and coverage
reiroop 25f2fe5
test: add unit tests for UI components and state logic
reiroop 16cad2f
test: fix Vuetify registration warnings and RepaidButton test
reiroop 4a14e3f
fix(client): reduce size of comment edit/delete buttons
reiroop 16af671
fix(client): adjust UI layout for images, header, and admin page
reiroop 3144ddf
fix: prevent double submission in NewApplicationPage
reiroop 1ddf5eb
refactor(client): remove shims and use defineModel
reiroop 1cddd44
fix(server): ensure run task always executes
reiroop d0415ef
fix(client): prevent double submission and redirect on success in New…
reiroop 6bc3666
fix(e2e): update create application test to wait for auto-redirection
reiroop 9436f95
feat(client): implement global toast notification and use it in NewAp…
reiroop 0d64d13
fix(client): remove unused variables in NewApplicationPage
reiroop 202f056
refactor: replace ref with useTemplateRef
reiroop d0a0d96
ci: update docker build config for vue3 migration
reiroop 0140f08
ci: update go version to 1.25
reiroop 5fee1e6
ci: enable docker build verification on PRs
reiroop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,9 @@ | ||
| name: Go | ||
| on: [push, pull_request] | ||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| build: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,4 +101,7 @@ tmp | |
| Jomon | ||
| uploads/* | ||
|
|
||
| .vscode | ||
| .vscode | ||
| coverage/ | ||
|
|
||
| .task/checksum/run | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,8 +11,6 @@ tasks: | |
| deps: [build] | ||
| cmds: | ||
| - /app/Jomon | ||
| sources: | ||
| - '**/*.go' | ||
|
|
||
| build: | ||
| desc: Build the Go application | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| module.exports = { | ||
| root: true, | ||
| env: { | ||
| node: true | ||
| }, | ||
| extends: [ | ||
| "plugin:vue/vue3-recommended", | ||
| "eslint:recommended", | ||
| "@vue/typescript/recommended", | ||
| "plugin:prettier/recommended" | ||
| ], | ||
| rules: { | ||
| // "no-console": process.env.NODE_ENV === "production" ? "error" : "off", | ||
| "no-console": process.env.NODE_ENV === "production" ? "warn" : "off", | ||
| "no-debugger": process.env.NODE_ENV === "production" ? "warn" : "off", | ||
| "vue/multi-word-component-names": "off", | ||
| "vue/max-attributes-per-line": "off", | ||
| "vue/html-indent": "off", | ||
| "vue/html-closing-bracket-newline": "off", | ||
| "vue/singleline-html-element-content-newline": "off", | ||
| "vue/multiline-html-element-content-newline": "off", | ||
| "vue/html-self-closing": "off" | ||
| }, | ||
| parserOptions: { | ||
| ecmaVersion: 2020 | ||
| } | ||
| }; |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,24 +1,54 @@ | ||
| # client | ||
| # Jomon Client | ||
|
|
||
| This is the frontend application for Jomon, built with Vue 3, Vite, and Pinia. | ||
|
|
||
| ## Tech Stack | ||
|
|
||
| - **Framework**: Vue 3 (Composition API) | ||
| - **Build Tool**: Vite | ||
| - **State Management**: Pinia | ||
| - **UI Framework**: Vuetify 3 | ||
| - **Testing**: Vitest (Unit), Playwright (E2E) | ||
| - **Language**: TypeScript | ||
|
|
||
| ## Project setup | ||
|
|
||
| ``` | ||
| npm install | ||
| ``` | ||
|
|
||
| ### Compiles and hot-reloads for development | ||
|
|
||
| ``` | ||
| npm run serve | ||
| npm run dev | ||
| ``` | ||
|
|
||
| ### Compiles and minifies for production | ||
|
|
||
| ``` | ||
| npm run build | ||
| ``` | ||
|
|
||
| ### Lints and fixes files | ||
|
|
||
| ``` | ||
| npm run lint | ||
| ``` | ||
|
|
||
| ### Run Tests | ||
|
|
||
| #### Component Tests (Vitest) | ||
|
|
||
| ```bash | ||
| npm run test | ||
| ``` | ||
|
|
||
| #### E2E Tests (Playwright) | ||
|
|
||
| ```bash | ||
| npm run test:e2e | ||
| ``` | ||
|
|
||
| ### Customize configuration | ||
| See [Configuration Reference](https://cli.vuejs.org/config/). | ||
|
|
||
| See [Vite Configuration Reference](https://vitejs.dev/config/). |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="ja"> | ||
| <head> | ||
| <meta charset="utf-8" /> | ||
| <meta http-equiv="X-UA-Compatible" content="IE=edge" /> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1.0" /> | ||
| <link rel="icon" href="/favicon.svg" type="image/svg+xml" /> | ||
| <title>Jomon</title> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://fonts.googleapis.com/css?family=Roboto:100,300,400,500,700,900" | ||
| /> | ||
| </head> | ||
| <body> | ||
| <noscript> | ||
| <strong | ||
| >We're sorry but client doesn't work properly without JavaScript | ||
| enabled. Please enable it to continue.</strong | ||
| > | ||
| </noscript> | ||
| <div id="app"></div> | ||
| <script type="module" src="/src/main.ts"></script> | ||
| </body> | ||
| </html> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.