feat: デプロイタイプに Function App を追加 #1077

cp-20 · 2025-07-13T14:25:53Z

なぜやるか

part of #1073

やったこと

デプロイタイプに Function App を追加した

やらなかったこと

フロントエンドでの設定画面
Function App のデプロイ部分

レビューしてほしい観点

既存の機能を破壊しないか
- 既存のコードもリファクタリング的にいじってるので、既存の機能が破壊されないかが重要
書き方がプロジェクトに沿ってるか

github-actions · 2025-07-13T14:25:59Z

Preview (prod backend + PR dashboard) → https://1077.ns-preview.trapti.tech/

Copilot

Pull Request Overview

Adds support for deploying Function Apps by introducing new function build configurations and extending existing build and deployment pipelines.

Introduces functionDest in builder state and new cleanup, extract, and save steps for function artifacts
Adds BuildConfigFunction* types across domain, repository converter, SQL migrations, and protobuf definitions
Refactors Dockerfile generation into generateBuildCmdDockerfile and updates pipeline steps in buildSteps

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
pkg/usecase/builder/state.go	Added `functionDest` field to track function artifact destination
pkg/usecase/builder/build_save_artifact.go	Renamed and split artifact saving for static vs function builds
pkg/usecase/builder/build_registry.go	Extracted registry cleanup into new method
pkg/usecase/builder/build_function.go	Implemented function artifact extraction
pkg/usecase/builder/build_buildpack.go	Added function buildpack support
pkg/usecase/builder/build_buildkit.go	Centralized Dockerfile generation and added function cmd steps
pkg/usecase/builder/build.go	Updated build pipeline with function build cases
pkg/infrastructure/repository/repoconvert/*	Mapped new function build configs and deploy type
pkg/infrastructure/repository/models/boil_types.go	Extended enums for function build and deploy types
pkg/domain/app_build_config.go	Defined `FunctionConfig` and new build config types
pkg/domain/app_artifact.go	Added constant for function artifact name
pkg/domain/app.go	Added `DeployTypeFunction`
migrations/schema.sql	Extended `deploy_type` and `application_config` enums
dashboard/.../applicationConfigSchema.ts	Stubbed frontend schema for function build configs
api/proto/.../gateway.proto	Added `FunctionConfig` and `BuildConfigFunction*` messages

Comments suppressed due to low confidence (2)

pkg/usecase/builder/build.go:139

New build steps for function buildpack are introduced here but no corresponding unit or integration tests have been added; consider adding tests to cover the function build path.

	case *domain.BuildConfigFunctionBuildpack:

pkg/usecase/builder/build_buildkit.go:227

A temporary Dockerfile is created but never cleaned up on error or after use; add defer cleanup() immediately after this line to remove the temp file.

	tmpName, cleanup, err := createTempFile("dockerfile-*", dockerfile)

Copilot · 2025-07-14T14:24:54Z

pkg/usecase/builder/build_save_artifact.go

+	var artifactBytes bytes.Buffer
+	gzipWriter := gzip.NewWriter(&artifactBytes)
+	_, err = io.Copy(gzipWriter, file)
+	if err != nil {
+		return errors.Wrap(err, "copying file to gzip writer")
+	}
+	err = gzipWriter.Close()
+	if err != nil {
+		return errors.Wrap(err, "flushing gzip writer")
+	}
+
+	// Save artifact by requesting to controller
+	err = s.client.SaveArtifact(ctx, artifact, artifactBytes.Bytes())


This buffers the entire artifact in memory before sending; for large artifacts it may be better to stream via an io.Pipe or chunked upload to reduce memory usage.

Suggested change

var artifactBytes bytes.Buffer

gzipWriter := gzip.NewWriter(&artifactBytes)

_, err = io.Copy(gzipWriter, file)

if err != nil {

return errors.Wrap(err, "copying file to gzip writer")

}

err = gzipWriter.Close()

if err != nil {

return errors.Wrap(err, "flushing gzip writer")

}

// Save artifact by requesting to controller

err = s.client.SaveArtifact(ctx, artifact, artifactBytes.Bytes())

pipeReader, pipeWriter := io.Pipe()

gzipWriter := gzip.NewWriter(pipeWriter)

// Start a goroutine to handle gzip compression and writing to the pipe

go func() {

defer pipeWriter.Close()

defer gzipWriter.Close()

_, err := io.Copy(gzipWriter, file)

if err != nil {

pipeWriter.CloseWithError(errors.Wrap(err, "copying file to gzip writer"))

}

}()

// Save artifact by requesting to controller

err = s.client.SaveArtifact(ctx, artifact, pipeReader)

これはあんまり問題にならなさそう？

Copilot · 2025-07-14T14:24:54Z

pkg/usecase/builder/build.go

-			return s.saveArtifact(ctx, st)
+			return s.saveTarGzArtifact(ctx, st)
+		}})
+	case *domain.BuildConfigFunctionBuildpack:


[nitpick] The function build cases repeat common cleanup and save logic across multiple config types; refactoring those into a shared helper could reduce duplication and improve maintainability.

一旦無視したい

… artifact にするように

pirosiki197

だいたいよさそうです！
既存のStaticBuildが壊れてないかだけ動作確認しておいてほしいです 🙏 (自分も確認します)

pirosiki197 · 2025-07-15T00:29:37Z

pkg/usecase/builder/build_buildkit.go

-	ch chan *buildkit.SolveStatus,
-	bc *domain.BuildConfigRuntimeCmd,
-) error {
+type BuildCmdOption struct {


公開する必要はなさそう？

pirosiki197 · 2025-07-22T05:17:13Z

pkg/usecase/builder/build_save_artifact.go

 	return nil
 }
+
+func (s *ServiceImpl) saveTarGzArtifact(ctx context.Context, st *state) error {


saveStaticArtifactとかがよさそう

pirosiki197 · 2025-07-22T05:31:06Z

pkg/usecase/builder/build_registry.go

+
+import "context"
+
+func (s *ServiceImpl) buildRegistryCleanup(


cleanupRegistryとかがよさそう

pirosiki197 · 2025-07-22T05:34:39Z

pkg/usecase/builder/build_extract.go

 }

-func (s *ServiceImpl) buildStaticCleanup(
+func (s *ServiceImpl) buildStaticExtract(


extractStaticArtifactとかがよさそう

pirosiki197 · 2025-07-22T05:43:51Z

pkg/usecase/builder/build_extract.go

 )

-func (s *ServiceImpl) buildStaticExtract(
+func (s *ServiceImpl) buildExtractFolderToTar(


extractDirectoryとかがよさそう

feat: デプロイタイプに Function App を追加

f2529e2

cp-20 self-assigned this Jul 13, 2025

cp-20 added 6 commits July 13, 2025 23:29

gen-proto

1f12c22

refactor

849e8d7

function app のビルド周りを真面目に書いた

f9609d3

Merge branch 'main' into feat/function-app-build

71c0246

fix typecheck

d4bb1dc

Merge branch 'main' into feat/function-app-build

76c38d2

cp-20 marked this pull request as ready for review July 14, 2025 14:16

function artifact を gzip 圧縮するように

bcae6e5

cp-20 requested a review from Copilot July 14, 2025 14:21

Copilot AI reviewed Jul 14, 2025

View reviewed changes

cp-20 requested a review from pirosiki197 July 14, 2025 14:29

cp-20 added 3 commits July 17, 2025 10:06

format schema.sql

57b4608

Merge branch 'main' into feat/function-app-build

3d0f172

Function App も Static App 同様に artifact path にフォルダ名を受け取って .tar.gz に固めて…

1b25bf8

… artifact にするように

pirosiki197 reviewed Jul 22, 2025

View reviewed changes

feat: デプロイタイプに Function App を追加 #1077

Are you sure you want to change the base?

feat: デプロイタイプに Function App を追加 #1077

Uh oh!

Conversation

cp-20 commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

なぜやるか

やったこと

やらなかったこと

レビューしてほしい観点

Uh oh!

github-actions bot commented Jul 13, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

cp-20 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

cp-20 Jul 14, 2025

Choose a reason for hiding this comment

Uh oh!

pirosiki197 left a comment

Choose a reason for hiding this comment

Uh oh!

pirosiki197 Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

pirosiki197 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

pirosiki197 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

pirosiki197 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

pirosiki197 Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cp-20 commented Jul 13, 2025 •

edited

Loading