不要なローカルセットアップ関数を削除 #109
Merged
不要なローカルセットアップ関数を削除 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://109-prod.rucq-ui-preview.trapti.tech/ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes an obsolete development setup file that was used for local backend initialization before the staging environment was available. The file posed a risk of accidentally wiping production or staging data if executed unintentionally.
- Removes the entire
src/dev/setup.tsfile which contained hardcoded development data setup - Eliminates potential risk of accidental execution against production/staging environments
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Pugma
requested changes
Sep 7, 2025
Pugma
left a comment
Pugma
left a comment
There was a problem hiding this comment.
これを消すのであれば、 /src/main.ts の l.33 にあるコメント部分も削除したほうがよさそう
Pugma
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setup.ts はまだ rucq-dev.trap.show もない頃の遺物です
ローカルにおけるバックエンドの初期設定を簡略化するために簡易的に作ったものですが、現在はステージング環境をいじる方が早いと思うので、基本的にはこのファイルは不要になっていそう
むしろ誤ってこれを実行することによって本番環境やステージング環境がまっさらになるリスクを重く見て、このファイルは削除してしまおうと思います