Fix/roominfo cache #126
Merged
Fix/roominfo cache #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://126-prod.rucq-ui-preview.trapti.tech/ |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where room ID was hardcoded instead of using dynamic room data, and reduces cache stale time for better data freshness.
- Fixed hardcoded room ID "201" to use dynamic room name from props
- Removed cache stale time configuration to use default shorter cache duration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/views/RoomInfoView.vue | Removed 3-hour stale time configuration for room groups query |
| src/components/information/RoomInfo.vue | Fixed hardcoded room ID to display actual room name from props |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
kitsne241
approved these changes
Sep 9, 2025
Collaborator
kitsne241
left a comment
kitsne241
left a comment
There was a problem hiding this comment.
私も見逃しててびっくりしました。良さそうです！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ユーザー情報のルームidが固定なバグの修正と、キャッシュのstaletimeの短縮を行いました