Skip to content

API keyの利用時にproxyを利用する #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Futadaruma merged 2 commits into from
Apr 15, 2025
Merged

API keyの利用時にproxyを利用する #312

Futadaruma merged 2 commits into from
Apr 15, 2025

Conversation

@Futadaruma
Copy link
Collaborator

@Futadaruma Futadaruma commented Apr 9, 2025

以下のPRと同じ変更です
traPtitech/traPortfolio-Dashboard#451

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Preview (prod) → https://312-prod.portfolio-preview.trapti.tech/
Preview (dev) → https://312-dev.portfolio-preview.trapti.tech/

@github-actions
Copy link

github-actions bot commented Apr 9, 2025

Failed to generate code suggestions for PR

@Futadaruma
Copy link
Collaborator Author

Futadaruma commented Apr 10, 2025

/review

@github-actions
Copy link

github-actions bot commented Apr 10, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

環境変数設定確認

新規に追加されたプロキシ関連の環境変数（OPENAI_KEY、OPENAI_API_BASE、CONFIG_MODEL、CONFIG_MODEL_TURBO）の設定内容が意図通りか、また既存のシークレット設定と整合性があるか確認してください。

 
uses: qodo-ai/[email protected]
env:
  OPENAI_KEY: ${{ secrets.OPENAI_PROXY_KEY }}
  OPENAI_API_BASE: 'https://llm-proxy.trap.jp'
  CONFIG_MODEL: 'gpt-4o'
  CONFIG_MODEL_TURBO: 'gpt-4o-mini'

@Futadaruma Futadaruma requested review from Pugma and sh0go07 April 12, 2025 12:27
Pugma
Pugma approved these changes Apr 15, 2025
View reviewed changes
Copy link
Collaborator

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

こちらも対応ありがとうございます！

こちらについても、リポジトリの設定から不要な secret は削除しておいてください

@Futadaruma Futadaruma merged commit 6a9a25e into main Apr 15, 2025
13 checks passed
@Futadaruma Futadaruma deleted the feat/use_proxy branch April 15, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pugma Pugma Pugma approved these changes

@sh0go07 sh0go07 Awaiting requested review from sh0go07

Assignees

No one assigned

Labels

Review effort 1/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Futadaruma @Pugma