💄 feat: MessageInputTextAreaに縦の伸長を追加 #4375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4375-prod.traq-preview.trapti.tech/ |
nokhnaton
reviewed
Oct 15, 2024
Contributor
nokhnaton
left a comment
nokhnaton
left a comment
There was a problem hiding this comment.
2024-10-15.202542.mp4
ちょっと触ってみたけど、focusしたときにサイズが変わるのは仕様としてわかりにくい気がするので、大きさを自分で変えられるとかの方がいいのかなと思った。(スマホのときの使いやすさは要検討)
編集の挙動はこれで良さそう。
src/components/Main/MainView/MessageInput/MessageInputTextArea.vue
Outdated
Show resolved
Hide resolved
reiroop
added a commit
that referenced
this pull request
Oct 19, 2024
Contributor
Author
|
トグルボタンを用意してmax-heightの大小を切り替えられるようにする方針 |
reiroop
added a commit
that referenced
this pull request
Jan 26, 2025
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
from
6ef4f08 to
4566405
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4375 +/- ##
=========================================
- Coverage 8.83% 8.81% -0.02%
=========================================
Files 671 671
Lines 29444 29508 +64
Branches 524 524
=========================================
Hits 2601 2601
- Misses 26837 26901 +64
Partials 6 6 ☔ View full report in Codecov by Sentry. |
MessageInputではonFocusのみ、MessageEditorでは常に伸長するように
MessageInputTextAreaコンポーネントにexists-height-limitプロパティを追加し、MessageEditorでfalseに設定しました。
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
from
4566405 to
53d3919
Compare
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
from
8c3a1a0 to
36c529b
Compare
…インディングによるインラインスタイルに変更
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
2 times, most recently
from
71532ed to
11f96df
Compare
…ize.update が走るように
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
from
9247451 to
5f296a0
Compare
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
2 times, most recently
from
a922eff to
0b29ec1
Compare
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
from
328b73e to
9cf0a4a
Compare
Contributor
|
スマホで動作を見てたんですが、ChevronDown (下向きのやつ) が現れる前と後で若干inputの幅が変わってガクッとなるのが気になりました 元の幅を変えないようにするのが良いかと思われます |
reiroop
force-pushed
the
feat/stretch-message-input-text-area
branch
from
394573a to
d0049bd
Compare
…除して、スマホのときに textAreaExpandButton の有無で input の幅が変わっていたバグを修正
…e.update が走っていなかったバグを修正
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
新規メッセージ入力ではトグルボタンで
max-heightを変更できるように、メッセージ編集ではmax-height: noneに