picaを使用しないようにして、iOSでの処理の分岐をやめた #4382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4382-prod.traq-preview.trapti.tech/ |
Pugma
approved these changes
Oct 24, 2024
Contributor
Pugma
left a comment
Pugma
left a comment
There was a problem hiding this comment.
確認しました！
よさそうです
今回修正されたトリガーについてはこれで大丈夫だと思うんですが、そもそもリサイズの基準が縦横の長さの絶対値で決まってそうで、面積とか画像サイズ基準じゃなさそうです
この辺りについてはどこかで見直したほうがよさそうだと感じています
ただ、これがどれほどうまくいきそうかも見当がつかないので一応ご意見を伺っておきたいです
Pugma
reviewed
Oct 24, 2024
Contributor
Author
|
#4388 建てました～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4302