コピーしたときのモーダルに説明をつけた #4384
Merged
コピーしたときのモーダルに説明をつけた #4384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4384-prod.traq-preview.trapti.tech/ |
Pugma
approved these changes
Oct 24, 2024
Contributor
Pugma
left a comment
Pugma
left a comment
There was a problem hiding this comment.
全体的にわかりやすくて良さそうです！
一点だけ確認をお願いします 🙇
| const copyEmbedded = async () => { | ||
| const link = `<iframe src="${embeddingOrigin}/widget/?type=message&id=${messageId.value}" scrolling="no" frameborder="no" width="600"></iframe>` | ||
| await copyText(link) | ||
| await copyText(link, '埋め込み') |
Contributor
There was a problem hiding this comment.
「埋め込み」をコピーだとちょっと日本語に違和感を覚えてしまったので、こんな感じにしてみてもいいと思います
ただ、ちょっと長いのでお任せします
Suggested change
| await copyText(link, '埋め込み') | |
| await copyText(link, 'メッセージ埋め込みテキスト') |
Contributor
Author
There was a problem hiding this comment.
あんまり長くしてもスマホで場所を取る&長くしたところで何がコピーされたかは伝わらなさそう(いい文言が思いつかない)なのでこのままでいいのかなと思います。
日本語的におかしいっていうのはたしかにそうで、めちゃくちゃいい指摘だと思います。:pro:
ただ今回はコピーされるものを端的に表す単語がないという状況なので、正確性よりかは短さを優先しちゃおうかと思います。
Contributor
There was a problem hiding this comment.
:haakusimasita: :yosasou: :desu:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4372