引用の日付をメッセージのものと合わせるように #4385
Merged
引用の日付をメッセージのものと合わせるように #4385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview (prod) → https://4385-prod.traq-preview.trapti.tech/ |
ras0q
requested changes
Oct 26, 2024
ras0q
reviewed
Oct 27, 2024
src/lib/basic/date.ts
Outdated
Comment on lines
71
to
81
|
|
||
| export const getDisplayDate = (createdAt: string, updatedAt: string) => { | ||
| return getDateRepresentation(updatedAt) | ||
| } | ||
| export const getDisplayDate = (createdAt: string, updatedAt?: string) => { | ||
| const createdAtUnix = Date.parse(createdAt) | ||
| const updatedAtUnix = Date.parse(updatedAt ?? '') | ||
| if (!Number.isNaN(updatedAtUnix)) { | ||
| return getDateRepresentation(new Date(updatedAtUnix)) | ||
| } | ||
|
|
||
| export const getCreatedDate = (createdAt: string) => { | ||
| return getDateRepresentation(createdAt) | ||
| return Number.isNaN(createdAtUnix) | ||
| ? '' | ||
| : getDateRepresentation(new Date(createdAtUnix)) | ||
| } |
Member
There was a problem hiding this comment.
現状はcreatedAtとupdatedAtのうち片方しか使われない（制御結合）形になっているんですが、↓のようにどちらを使うかは外側で決めて変換には必要な日付のみを渡す（データ結合）方がモジュール結合度が低くて運用しやすいんじゃないかなって思います
つまりはgetDisplayDateは消してgetDateRepresentationを広く使いたいねって話です（関数名はgetDisplayDateでもいいんですが）
Contributor
Author
There was a problem hiding this comment.
あー、確かにこんな感じの使い方がありえるならgetDateRepresentationを広く使う方が良さそうですね
ras0q
reviewed
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #4368