-
Notifications
You must be signed in to change notification settings - Fork 44
メンションの前に:がつくとメンションできない問題を修正 #4399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Preview (prod) → https://4399-prod.traq-preview.trapti.tech/ |
Pugma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
実装は概ね良さそうだと思いますが、テストコードの編集がされてなさそうです
/tests/unit/lib/markdown/internalLinkEmbeddeder.spec.ts への反映もお願いします!
|
テスト追加しました~! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4399 +/- ##
=========================================
- Coverage 8.93% 8.91% -0.02%
=========================================
Files 671 672 +1
Lines 29658 29765 +107
Branches 528 533 +5
=========================================
+ Hits 2649 2654 +5
- Misses 27003 27104 +101
- Partials 6 7 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pugma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
レビュー大変遅くなりました
こちら大丈夫だと思います!
No description provided.