Skip to content

Conversation

@nokhnaton
Copy link
Contributor

No description provided.

@github-actions
Copy link

Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

実装は概ね良さそうだと思いますが、テストコードの編集がされてなさそうです
/tests/unit/lib/markdown/internalLinkEmbeddeder.spec.ts への反映もお願いします!

@nokhnaton
Copy link
Contributor Author

テスト追加しました~!

@codecov
Copy link

codecov bot commented May 9, 2025

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 8.91%. Comparing base (b15080a) to head (c36e5ad).
Report is 216 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/markdown/internalLinkEmbedder.ts 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #4399      +/-   ##
=========================================
- Coverage    8.93%   8.91%   -0.02%     
=========================================
  Files         671     672       +1     
  Lines       29658   29765     +107     
  Branches      528     533       +5     
=========================================
+ Hits         2649    2654       +5     
- Misses      27003   27104     +101     
- Partials        6       7       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Takeno-hito Takeno-hito requested a review from Pugma May 9, 2025 15:12
Copy link
Contributor

@Pugma Pugma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビュー大変遅くなりました
こちら大丈夫だと思います!

@nokhnaton nokhnaton merged commit b0faf14 into master Jun 16, 2025
11 checks passed
@nokhnaton nokhnaton deleted the fix/not_mention_start_with_colon branch June 16, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants