test: validate config.cfg against deprecated cloud instance types#14958
Merged
test: validate config.cfg against deprecated cloud instance types#14958
Conversation
Replace toy data tests with actual config.cfg validation to catch deprecated instance types before deployment fails. Checks for: - Hetzner Intel CX series (removed Sept 2024, use AMD CPX) - DigitalOcean old naming scheme (use s-*vcpu-* format) - EC2 previous gen types (unavailable in VPC) Also adds basic sanity checks for required fields and malformed values. Refs #14730 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config.cfgvalidationDeprecated values checked
server_typecx11,cx21,cx31,cx41,cx51cpx22, etc.)size512mb,1gb,2gb, etc.s-*vcpu-*formatsizet1.micro,m1.small, etc.t3.*, etc.)Why not regex format validation?
Providers constantly add new instance families (AWS
m7.*,g5.*, etc.). Regex patterns would break on legitimate new values, creating false CI failures. Instead, we only block known-bad values that are definitively deprecated.Test plan
pytest tests/unit/test_cloud_provider_configs.py -vpassescx11)Refs #14730
🤖 Generated with Claude Code