Add a simple Rust version to the mix #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .map(|bite| { | ||
| bite.parse() | ||
| .ok() | ||
| .expect(&format!("failed to read {} as integer", bite)) |
There was a problem hiding this comment.
.unwrap() will basically do that directly
|
Great! You may accelerate csa using unsafe code: carefully check that the data structure is bound consistent, and use |
| let mut input_line = String::new(); | ||
| io::stdin().read_line(&mut input_line) | ||
| .ok() | ||
| .expect("failed to read connection line"); |
There was a problem hiding this comment.
It seems I'm not bleeding edge enough…
error: use of unstable library feature 'result_expect': newly introduced
Signez
force-pushed
the
rust
branch
2 times, most recently
from
7a8fc53 to
e220cc0
Compare
|
Thank you very much for this extensive review! As it is only my second Rust usage, I wasn't very confident… I owe you a beer 😉 |
|
Cool :) |
Thanks @TeXitoi for your insights on Rust code.
Tristramg
added a commit
that referenced
this pull request
Aug 31, 2015
Add a simple Rust version to the mix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably not the best in town, but it seems to have correct perfs (near C++).