Align nested_identifier -> member_expression alias field names #267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds field names to the existing
nested_identifier
rule (which gets used for dotted JSX element names eg<Foo.Bar />
) so that when it gets aliased to$.member_expression
it has the same field names as a "normal"member_expression
(ieobject
andproperty
)This seems desirable to me so that one can treat it as an "invariant" that when you see a
member_expression
node it definitely hasobject
andproperty
fieldsChecklist:
Successfully parsed 2615 of 2616 example files (100.0%)
)