Support HTML entities in JSX text/attributes #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSX text and attributes support HTML character references (a.k.a. entities), and don't support ECMAScript string escape sequences. Although the [spec] calls it "historical" and threatens to change it, it _is_ in the spec, and the spec is pretty stable at this point. In changing this, I landed back on an idea that @maxbrunsfeld suggested in a [PR review] some time ago: having separate `string` and `jsx_string` nodes, and aliasing `jsx_string` to `string` for consumers' convenience. At that time, having two different node types was deemed unnecessary, but this adds a second, more substantive difference between the two, so I've brought the idea back, and stopped allowing invalid newlines in JS string literals, which is invalid in both JS and TS. [spec]: https://facebook.github.io/jsx/#sec-jsx-string-characters [PR review]: tree-sitter#140 (comment)
|
I'm going to build on top of this with a fix for jsx vs js strings as well, thank you for the PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSX text and attributes support HTML character references (a.k.a. entities), and don't support ECMAScript string escape sequences.
Although the spec calls it "historical" and threatens to change it, it is in the spec, and the spec is pretty stable at this point.
In changing this, I landed back on an idea that @maxbrunsfeld suggested in a PR review some time ago: having separate
stringandjsx_stringnodes, and aliasingjsx_stringtostringfor consumers' convenience. At that time, having two different node types was deemed unnecessary, but this adds a second, more substantive difference between the two, so I've brought the idea back, and stopped allowing invalid newlines in JS string literals, which is invalid in both JS and TS.TL;DR
Here is some JSX highlighted in Neovim using tree-sitter:
And here it is in VSCode, not using tree-sitter:
VSCode, correctly, does not highlight the
\nin the JSX attribute, and does highlight the two valid s, which tree-sitter-javascript doesn't currently parse. This PR fixes both things.Checklist: