optimize fallback_sort
#113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loops over inclusive (a..=b) ranges are known to cause issues in LLVM. Here the impact is especially large, Benchmark 2 (416 runs): target/relwithdebinfo/examples/compress rs 1 tests/input/quick/sample3.ref measurement mean ± σ min … max outliers delta wall_time 12.0ms ± 236us 11.6ms … 15.8ms 23 ( 6%) ⚡- 5.2% ± 0.3% peak_rss 3.20MB ± 68.7KB 3.01MB … 3.28MB 0 ( 0%) + 0.1% ± 0.3% cpu_cycles 47.7M ± 937K 46.5M … 64.1M 17 ( 4%) ⚡- 5.7% ± 0.2% instructions 215M ± 313 215M … 215M 5 ( 1%) ⚡- 6.3% ± 0.0% cache_references 4.63M ± 107K 4.24M … 5.10M 8 ( 2%) + 0.5% ± 0.3% cache_misses 253K ± 31.8K 109K … 362K 7 ( 2%) ⚡- 9.4% ± 1.7% branch_misses 82.7K ± 385 82.2K … 89.1K 29 ( 7%) - 0.6% ± 0.1%
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
bjorn3
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we work around 2 issues in rustc/llvm:
Ord::cmpis less efficient than an if-else sequencea..=bare less efficient than loops over exclusive ranges