clippy fixes for 1.88.0

.github/workflows/checks.yaml

@@ -73,7 +73,7 @@ jobs:
         run: "rustc -vV | sed -n 's|host: ||p'"
         if: matrix.os != 'windows-2022'
       - name: Install cargo-llvm-cov & cargo-nextest
-        uses: taiki-e/install-action@a48a50298f98c47e46a957ae6f82c44cc4878e42 # v2.49.47
+        uses: taiki-e/install-action@d12e869b89167df346dd0ff65da342d1fb1202fb # v2.53.2
         with:
           tool: cargo-llvm-cov,cargo-nextest
       - name: cargo build
@@ -146,7 +146,7 @@ jobs:
       - name: target
         run: "rustc -vV | sed -n 's|host: ||p'"
       - name: Install cargo-nextest
-        uses: taiki-e/install-action@a48a50298f98c47e46a957ae6f82c44cc4878e42 # v2.49.47
+        uses: taiki-e/install-action@d12e869b89167df346dd0ff65da342d1fb1202fb # v2.53.2
         with:
           tool: cargo-nextest
       - name: cargo build
@@ -310,7 +310,7 @@ jobs:
       - name: target
         run: "rustc -vV | sed -n 's|host: ||p'"
       - name: Install cargo-nextest
-        uses: taiki-e/install-action@a48a50298f98c47e46a957ae6f82c44cc4878e42 # v2.49.47
+        uses: taiki-e/install-action@d12e869b89167df346dd0ff65da342d1fb1202fb # v2.53.2
         with:
           tool: cargo-nextest
       - name: Download wasi-sdk
@@ -340,7 +340,7 @@ jobs:
           rustup toolchain install nightly --component miri
           cargo +nightly miri setup
       - name: Install cargo-nextest
-        uses: taiki-e/install-action@a48a50298f98c47e46a957ae6f82c44cc4878e42 # v2.49.47
+        uses: taiki-e/install-action@d12e869b89167df346dd0ff65da342d1fb1202fb # v2.53.2
         with:
           tool: cargo-nextest
       - name: Test public C api with miri

bzip2.rs

@@ -972,7 +972,7 @@
         "\tProbably you can fix this by defining them correctly,\n",
         "\tand recompiling.  Bye!\n",
     );
-    eprint!("{}", MSG);
+    eprint!("{MSG}");
     setExit(3);
     exit(exitValue.load(Ordering::SeqCst));
 }

bzip2recover.rs

@@ -132,7 +132,7 @@ impl core::fmt::Display for EmitError<'_> {
                     self.in_filename.display(),
                 )?;
 
-                writeln!(f, "{}", io_error)?;
+                writeln!(f, "{io_error}")?;
 
                 writeln!(
                     f,
@@ -150,7 +150,7 @@ impl core::fmt::Display for EmitError<'_> {
                     self.in_filename.display(),
                 )?;
 
-                writeln!(f, "{}", io_error)?;
+                writeln!(f, "{io_error}")?;
 
                 writeln!(
                     f,
@@ -211,7 +211,7 @@ fn main_help(program_name: &Path, in_filename: &Path) -> Result<(), Error> {
     };
 
     let mut input_bitstream = BitStream::open_read_stream(input_file);
-    eprintln!("{}: searching for block boundaries ...", progname);
+    eprintln!("{progname}: searching for block boundaries ...");
 
     let mut bits_read: u64 = 0;
     let mut buff_lo: u32 = 0;
@@ -278,12 +278,12 @@ fn main_help(program_name: &Path, in_filename: &Path) -> Result<(), Error> {
     /*-- identified blocks run from 1 to rbCtr inclusive. --*/
 
     if rb_ctr < 1 {
-        eprintln!("{}: sorry, I couldn't find any block boundaries.", progname);
+        eprintln!("{progname}: sorry, I couldn't find any block boundaries.");
 
         return Err(Error::Fatal);
     }
 
-    eprintln!("{}: splitting into blocks", progname);
+    eprintln!("{progname}: splitting into blocks");
 
     let Ok(input_file) = std::fs::File::options().read(true).open(in_filename) else {
         eprintln!("{}: can't read `{}'", progname, in_filename.display());
@@ -376,7 +376,7 @@ fn main_help(program_name: &Path, in_filename: &Path) -> Result<(), Error> {
         }
     }
 
-    eprintln!("{}: finished", progname);
+    eprintln!("{progname}: finished");
 
     Ok(())
 }
@@ -409,7 +409,7 @@ fn main() -> ExitCode {
                 error,
             };
 
-            eprint!("{}", emit_error);
+            eprint!("{emit_error}");
 
             ExitCode::FAILURE
         }
@@ -435,7 +435,7 @@ mod test {
         };
 
         let mut buf = String::new();
-        write!(&mut buf, "{}", emit_error).unwrap();
+        write!(&mut buf, "{emit_error}").unwrap();
 
         assert_eq!(
             buf,
@@ -470,7 +470,7 @@ mod test {
         };
 
         let mut buf = String::new();
-        write!(&mut buf, "{}", emit_error).unwrap();
+        write!(&mut buf, "{emit_error}").unwrap();
 
         assert_eq!(
             buf,
@@ -504,7 +504,7 @@ mod test {
         };
 
         let mut buf = String::new();
-        write!(&mut buf, "{}", emit_error).unwrap();
+        write!(&mut buf, "{emit_error}").unwrap();
 
         assert_eq!(
             buf,

tests/quick.rs

@@ -1570,7 +1570,7 @@ mod compress_command {
 
         let output = match cmd.output() {
             Ok(output) => output,
-            Err(err) => panic!("Running {:?} failed with {err:?}", cmd),
+            Err(err) => panic!("Running {cmd:?} failed with {err:?}"),
         };
 
         assert!(