Skip to content

Conversation

@folkertdev
Copy link
Member

this gives mostly improvements, some instruction count increases but no increases in wall time as far as I can tell

Benchmark 2 (10 runs): target/release/examples/decompress rs tests/input/bzip2-testfiles/go/regexp/re2-exhaustive.txt.bz2
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           507ms ± 3.72ms     497ms …  511ms          1 (10%)          -  0.9% ±  1.0%
  peak_rss           67.5MB ±    0      67.5MB … 67.5MB          0 ( 0%)          -  0.0% ±  0.0%
  cpu_cycles         2.19G  ± 12.6M     2.17G  … 2.21G           2 (20%)          -  1.2% ±  0.9%
  instructions       2.86G  ±  355      2.86G  … 2.86G           0 ( 0%)        💩+  3.0% ±  0.0%
  cache_references    110M  ±  236K      109M  …  110M           0 ( 0%)          -  0.5% ±  0.4%
  cache_misses       28.2M  ±  172K     27.9M  … 28.5M           0 ( 0%)        ⚡-  2.1% ±  0.7%
  branch_misses      1.61M  ± 6.70K     1.60M  … 1.62M           0 ( 0%)        ⚡-  3.4% ±  0.3%

Benchmark 2 (10 runs): target/release/examples/decompress rs tests/input/bzip2-testfiles/go/regexp/re2-exhaustive.txt.bz2
  measurement          mean ± σ            min … max           outliers         delta
  wall_time           505ms ± 7.56ms     485ms …  510ms          1 (10%)          -  1.6% ±  1.2%
  peak_rss           67.5MB ±    0      67.5MB … 67.5MB          0 ( 0%)          +  0.0% ±  0.0%
  cpu_cycles         2.18G  ± 36.3M     2.08G  … 2.20G           1 (10%)          -  1.7% ±  1.1%
  instructions       2.86G  ±  267      2.86G  … 2.86G           0 ( 0%)        💩+  3.0% ±  0.0%
  cache_references    109M  ±  369K      109M  …  110M           0 ( 0%)          -  0.1% ±  0.3%
  cache_misses       28.1M  ± 55.7K     28.0M  … 28.2M           0 ( 0%)        ⚡-  1.8% ±  0.5%
  branch_misses      1.61M  ± 4.67K     1.60M  … 1.62M           1 (10%)        ⚡-  3.5% ±  0.3%

Benchmark 2 (795 runs): target/release/examples/decompress rs tests/input/quick/sample2.bz2
  measurement          mean ± σ            min … max           outliers         delta
  wall_time          6.25ms ±  133us    5.94ms … 8.07ms         18 ( 2%)        ⚡-  3.3% ±  0.3%
  peak_rss           3.02MB ± 18.0KB    2.88MB … 3.15MB         15 ( 2%)          +  0.0% ±  0.0%
  cpu_cycles         22.2M  ±  350K     21.9M  … 29.5M          54 ( 7%)        ⚡-  4.0% ±  0.3%
  instructions       39.3M  ±  298      39.2M  … 39.3M           7 ( 1%)        ⚡- 10.2% ±  0.0%
  cache_references    349K  ± 34.1K      340K  … 1.07M         104 (13%)          -  1.3% ±  1.9%
  cache_misses       78.2K  ± 1.74K     74.3K  … 86.7K          21 ( 3%)        ⚡-  1.4% ±  0.2%
  branch_misses       272K  ±  939       269K  …  276K           8 ( 1%)        ⚡-  8.5% ±  0.0%

@folkertdev folkertdev force-pushed the shrink-random-lookup-table branch from ae2abdd to 3d4c25c Compare June 29, 2025 15:08
@codecov
Copy link

codecov bot commented Jun 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
fuzz-compress_then_decompress 50.25% <ø> (-0.20%) ⬇️
fuzz-decompress_chunked 33.42% <ø> (+2.82%) ⬆️
test-aarch64-apple-darwin 89.49% <ø> (ø)
test-x86_64-apple-darwin 89.49% <ø> (ø)
test-x86_64-unknown-linux-gnu 89.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
libbz2-rs-sys/src/bzlib.rs 95.57% <ø> (+0.68%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@folkertdev folkertdev force-pushed the shrink-random-lookup-table branch from 17d5d45 to 914093b Compare June 29, 2025 15:21
@folkertdev
Copy link
Member Author

The install action started downloading cargo-fuzz built for musl again, so now we're just cargo install'ing it.

@folkertdev folkertdev requested a review from bjorn3 June 29, 2025 15:26
@folkertdev folkertdev merged commit 8cdd6a9 into main Jun 30, 2025
23 checks passed
@folkertdev folkertdev deleted the shrink-random-lookup-table branch June 30, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants