Remove Windows GNU restriction and add CI build for MSVC #119
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
folkertdev
left a comment
folkertdev
left a comment
There was a problem hiding this comment.
Neat, thanks!
Do you have cause to use these binaries on msvc?
| #[cfg(all(target_os = "windows", target_env = "gnu"))] | ||
| #[cfg(target_os = "windows")] | ||
| extern "C" { | ||
| fn __acrt_iob_func(idx: libc::c_uint) -> *mut FILE; |
There was a problem hiding this comment.
Is this also the correct implementation when using the ucrt.dll and not just msvcrt.dll?
There was a problem hiding this comment.
I don't know but now it'll at least build. We don't currently really intend to support the binaries anyway, and for windows the high-level interface is also just nice if it works (bzip2 only uses the low-level interface, where we do really care that it works on windows of course).
Is there a simple way to test for the scenario you describe in CI (I'm really not familiar with msvc)
There was a problem hiding this comment.
The x86_64-pc-windows-gnullvm target uses the ucrt.
3 participants
It seems overly restrictive to not allow the library to compile on Windows MSVC. I have removed the
target_env = gnurestrictions and added a CI build for the MSVC target.