decompress.rs: faster input reading
#85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
bjorn3
reviewed
Jan 22, 2025
bjorn3
reviewed
Jan 22, 2025
bjorn3
reviewed
Jan 22, 2025
bjorn3
reviewed
Jan 22, 2025
bjorn3
reviewed
Jan 22, 2025
bjorn3
reviewed
Jan 22, 2025
| if self.avail_in < 8 { | ||
| return None; | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe add a debug assertion that no more than 7 bytes are requested? And no more than 1 byte in the case of pull_u8.
Member
Author
There was a problem hiding this comment.
well I added an assert that we can at least consume 1 additional byte, in other words that we don't ask for more input if we don't have space in the bit buffer.
The check you comment on is a bounds check, so we just skip this function if there are not 8 additional bytes in the input, there is nothing to assert there right?
folkertdev
force-pushed
the
decompress-faster-input-reading
branch
from
6dd666f to
c78469e
Compare
bjorn3
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
attempt to read up to 7 bytes at once, cutting down on the total number of reads. This has some nice performance benefits.