Use more expressive error messages when failing out in visudo#1157
Conversation
Old error message: ``` visudo: Permission denied (os error 13) ``` Newer error message: ``` visudo: Failed to open existing sudoers file at "/etc/sudoers": Permission denied (os error 13) ``` (etc) Signed-off-by: Sohom <sdatta4@ncsu.edu>
|
Retroactively filling this out since Github didn't freakin prompt me :( Pull Request Checklist
(#835 was the closest I could find, but I also assumed that this would be considered a small change under the Contributing guidelines) |
|
#835 is the relevant issue---improving the error message you quoted was the prime objective. To fully close #835 we might want to look at error messages in case PAM is misconfigured (e.g. no PAM profile can be loaded due to a missing note: We currently don't use PR templates; it's appreciated that you took the time to use the checklist, but it's not a hard requirement on this repository. I have some reservations about forcing people to "tick boxes". For example, the 'code of conduct' is not a "contract" you have to "accept", it's simply something we expect. Some of the other things are checked in CI or code review. |
|
Thanks for your contribution! |
Old error message:
Newer error message:
(etc)