Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Conversation

@trimox
Copy link
Owner

@trimox trimox commented Feb 11, 2020

Adds the R generic parameter to MdcDialog open method; allows for the dialog result to be strongly typed.

@trimox trimox added this to the v5.0.1 milestone Feb 11, 2020
@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #2074 into master will decrease coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2074      +/-   ##
==========================================
- Coverage   90.42%   90.29%   -0.13%     
==========================================
  Files         100      100              
  Lines        4364     4275      -89     
  Branches      568      551      -17     
==========================================
- Hits         3946     3860      -86     
+ Misses        208      206       -2     
+ Partials      210      209       -1
Impacted Files Coverage Δ
packages/chips/module.ts 100% <ø> (ø) ⬆️
packages/chips/chip-directives.ts 100% <100%> (ø) ⬆️
packages/chips/chip.ts 85.88% <100%> (-3.67%) ⬇️
packages/dialog/dialog.component.ts 85.33% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e31939d...d2ca35a. Read the comment docs.

@trimox trimox merged commit 7dbcadd into master Feb 12, 2020
@trimox trimox deleted the feat/dialog-generic-result branch February 12, 2020 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants