Skip to content

Use clang-12 to fix issue with LLVM_ABI_BREAKING_CHECKS #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 28 additions & 6 deletions .github/workflows/llvm-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,34 @@ jobs:
key: ${{ matrix.config.target-os }}-${{ matrix.config.arch }}-${{ env.short_llvm_commit_hash }}
restore-keys: ${{ matrix.config.target-os }}-${{ matrix.config.arch }}-

- name: Configure, Build, Test, and Install LLVM (Ubuntu and macOS x64)
if: matrix.config.arch == 'x64' && (matrix.config.target-os == 'ubuntu' || matrix.config.target-os == 'macos')
- name: Configure, Build, Test, and Install LLVM (Ubuntu)
if: matrix.config.arch == 'x64' && (matrix.config.target-os == 'ubuntu')
run: >
python3 -m pip install -r llvm-project/mlir/python/requirements.txt

cmake -GNinja -Bllvm-project/build
-DCMAKE_BUILD_TYPE=Release
-DCMAKE_C_COMPILER=clang-12 -DCMAKE_CXX_COMPILER=clang++-12
-DCMAKE_C_COMPILER_LAUNCHER=sccache -DCMAKE_CXX_COMPILER_LAUNCHER=sccache
-DCMAKE_INSTALL_PREFIX="${{ env.llvm_install_dir }}"
-DCMAKE_LINKER=lld
-DLLVM_BUILD_UTILS=ON
-DLLVM_BUILD_TOOLS=ON
-DLLVM_ENABLE_ASSERTIONS=ON
-DMLIR_ENABLE_BINDINGS_PYTHON=ON
-DLLVM_ENABLE_PROJECTS=mlir
-DLLVM_INSTALL_UTILS=ON
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU"
-DLLVM_ENABLE_TERMINFO=OFF
llvm-project/llvm

ninja -C llvm-project/build check-mlir install

tar czf "${{ env.llvm_install_dir }}.tar.gz" "${{ env.llvm_install_dir }}"


- name: Configure, Build, Test, and Install LLVM (macOS x64)
if: matrix.config.arch == 'x64' && (matrix.config.target-os == 'macos')
run: >
python3 -m pip install -r llvm-project/mlir/python/requirements.txt

Expand All @@ -107,7 +133,6 @@ jobs:
-DLLVM_INSTALL_UTILS=ON
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU"
-DLLVM_ENABLE_TERMINFO=OFF
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF
llvm-project/llvm

ninja -C llvm-project/build check-mlir install
Expand All @@ -131,7 +156,6 @@ jobs:
-DLLVM_INSTALL_UTILS=ON
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU"
-DLLVM_ENABLE_TERMINFO=OFF
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF
llvm-project/llvm

ninja -C llvm-project/build check-mlir install
Expand Down Expand Up @@ -177,7 +201,6 @@ jobs:
-DCMAKE_LINKER=$LINKER \
-DMLIR_ENABLE_BINDINGS_PYTHON=ON \
-DLLVM_ENABLE_ZSTD=OFF \
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF \
-DLLVM_INSTALL_UTILS=ON \
-DCMAKE_INSTALL_PREFIX="${{ env.llvm_install_dir }}" \
-DLLVM_TARGETS_TO_BUILD="AArch64;NVPTX;AMDGPU" \
Expand Down Expand Up @@ -228,7 +251,6 @@ jobs:
-DLLVM_TARGETS_TO_BUILD="AArch64;NVPTX;AMDGPU"
-DLLVM_USE_HOST_TOOLS=ON
-DLLVM_ENABLE_TERMINFO=OFF
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF
llvm-project/llvm

ninja -C llvm-project/build install
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/llvm-build/almalinux.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ RUN cmake -GNinja -Bbuild \
-DLLVM_ENABLE_PROJECTS=mlir \
-DLLVM_ENABLE_TERMINFO=OFF \
-DLLVM_INSTALL_UTILS=ON \
-DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF \
-DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU" \
/source/llvm-project/llvm

Expand Down
2 changes: 1 addition & 1 deletion cmake/llvm-hash.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
36adf8ecedb64047021265a1e1730773d3b3a9e8
c8fcfe1980999688f22a4ee53ec7c65c8c055752
Loading