-
Notifications
You must be signed in to change notification settings - Fork 15
Add simple SGS to Adami and Morris Viscosity #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #753 +/- ##
==========================================
+ Coverage 70.53% 71.13% +0.60%
==========================================
Files 96 106 +10
Lines 5976 6753 +777
==========================================
+ Hits 4215 4804 +589
- Misses 1761 1949 +188
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl
Outdated
Show resolved
Hide resolved
validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl
Outdated
Show resolved
Hide resolved
Can you explain the plots please? What are you showing? Is lower or higher better? And I can't tell the points in the first plot apart. |
These are the csv files plotted you receive when running the TGV validation case so this is time over the error. So lower is better. This is not really an accuracy improving method. So this only shows that the results are reasonable and with tuning results could be improved. I would see this is more as a method to obtain additional stability for high Reynolds number flows or suppressing spurious reflections at adaption level jumps. |
It would also make sense to merge #801 first |
TGV:




This shows the default values give reasonable results
With C_S=0.5:

