Add Odysseus to community train#5113
Conversation
stavros-k
left a comment
stavros-k
left a comment
There was a problem hiding this comment.
Your LLM spent zero time reviewing other app's structure.
|
|
||
| {# SearXNG Container (Optional) #} | ||
| {% if values.odysseus.use_local_searxng %} | ||
| {% set searxng = tpl.add_container("searxng", "searxng_image") %} |
There was a problem hiding this comment.
there is already an app for that.
No reason to embed.
| {% endif %} | ||
|
|
||
| {# Ntfy Container #} | ||
| {% set ntfy = tpl.add_container("ntfy", "ntfy_image") %} |
There was a problem hiding this comment.
there is already an app for that.
No reason to embed.
There was a problem hiding this comment.
I don't think I understand what you mean by that. Ntfy is not in the deps, so I wasn't able to pull it from there, so I though I just need to embed it here. I looked at some other apps and I see that they either use deps module or just embed things. What is the path you want me to take here? Should I commit with a change to deps module?
| run_as_user: 568 | ||
| run_as_group: 568 |
There was a problem hiding this comment.
Odysseus had static run_as in its docker compose. I am running it on my truenas as custom app with static with these values and I saw most of the apps have static run_as, so I figured I will also do static run_as with "apps" id here.
There was a problem hiding this comment.
Leftover file I was basing configuration on with my docker_compose I was using in the custom app deployment on my truenas
It did and I also did spent some time. And it seems we were both wrong on some things. |
2 participants
App Addition
AI
It was my first PR for truenas app and at first I wasn't that familiar with the structure, so I used Qwen3.5 to get to know the structure better before making the changes and assess if I made any errors in the changes before making the PR.
Description
Adds Odysseus to the community train.
Odysseus is a AI Chat tool with RAG, Deep Search, Web Search, Code editing, and more. Also includes image editor, task planning & email handling. Project was started by PewDiePie
App Information
Testing
Tested locally with:
All tests passed successfully. The only errors were with printing docker-compose at the end (unknown shorthand flag: 'p' in -p), but that's not a test nor changes -related error. There's propably a docker version mismatch between test suite and my version. I checked the generated yamls and they were correct.
Icons and Screenshots
Please upload the following to the CDN:
Special Notes
Checklist