XMRig: Add MSR instructions, conditionally enable volumes, fix namings#5133
XMRig: Add MSR instructions, conditionally enable volumes, fix namings#5133Keeqler wants to merge 2 commits into
Conversation
| - variable: local_xmrig_port | ||
| label: XMRig Port | ||
| description: The port your XMRig app is listening on. | ||
| - variable: local_p2pool_port |
There was a problem hiding this comment.
Changing the schema shape (ie variable name) will make upgrades fail due to invalid set of keys.
There was a problem hiding this comment.
Maybe I can keep both and make the incorrectly named one always hidden? Lmk if this is allowed.
There was a problem hiding this comment.
I dont want to carry over fields like that. It needs a migration, but if its just a name change, why not just update the label?
There was a problem hiding this comment.
Since we are doing a migration anyway, we can rename this as well
| Enabling this may increase the hashrate by 10-30%, but will grant XMRig privileged | ||
| access to the host. | ||
| access to the host.</br> | ||
| IMPORTANT: For this to work, you need to load the MSR kernel module on the host every |
There was a problem hiding this comment.
The rule is to not push users to modify host. So if tho it's the case it needs to be removed. If user wants this enabled it either does so via custom app or env or some other form of customisation
There was a problem hiding this comment.
Okay, should I just remove the message telling the user to enable MSR? Or do you want me to drop the entire feature?
There was a problem hiding this comment.
We should remove it with a migration.
2 participants
No description provided.