(fix) Indeterminate verification issue in Clickup detector

[abmussani]

Description:

This PR covers all the cases which can cause indeterminate verification issue in Clickup Detector. Also, I noted that Clickup has a very little modification in its token structure.

Checklist:

• Tests passing (make test-community)?
• Lint passing (make lint this requires golangci-lint)?

[ahrav]

nit: Looks like the linter isn't a huge fan of the blank identifier here. We can get rid of it since we only need the key from the map.

[abmussani]

Strange part is my golangci-lint version is not raising this issue.

[nabeelalam]

Suggestion: We can update the integration test for the failed verification with error case:

{
	name: "found verifiable secret, verification failed due to unexpected API response",
	s:    Scanner{client: common.ConstantResponseHttpClient(404, "")},
	args: args{
		ctx:    context.Background(),
		data:   []byte(fmt.Sprintf("You can find a clickuppersonaltoken secret %s within", secret)),
		verify: true,
	},
	want: []detectors.Result {
		{
			DetectorType: detectorspb.DetectorType_ClickupPersonalToken,
			Verified:     false,
		}
	},
	wantErr: false,
	wantVerificationErr: true,
},

[abmussani]

Suggestion: We can update the integration test for the failed verification with error case:

{
	name: "found verifiable secret, verification failed due to unexpected API response",
	s:    Scanner{client: common.ConstantResponseHttpClient(404, "")},
	args: args{
		ctx:    context.Background(),
		data:   []byte(fmt.Sprintf("You can find a clickuppersonaltoken secret %s within", secret)),
		verify: true,
	},
	want: []detectors.Result {
		{
			DetectorType: detectorspb.DetectorType_ClickupPersonalToken,
			Verified:     false,
		}
	},
	wantErr: false,
	wantVerificationErr: true,
},

I have added the test case failed verification error.

[nabeelalam]

I think this commented line can be removed

[nabeelalam]

Looks great. Thanks @abmussani