Skip to content

Conversation

@HavenDV
Copy link
Contributor

@HavenDV HavenDV commented Sep 8, 2025

Summary by CodeRabbit

  • New Features

    • Call and daily call statistics now include “billed minutes,” providing clearer billing insights across reports, dashboards, and exports.
    • API responses now return the billedMinutes value for each statistics record.
  • Chores

    • Updated API schema to make billedMinutes a required field in CallStatistics and DailyCallStatistics. Clients using strict schemas may need to update integrations.

@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

Walkthrough

Added a new required billedMinutes (number, double) field to CallStatistics and DailyCallStatistics schemas in src/libs/Ultravox/openapi.yaml.

Changes

Cohort / File(s) Change Summary
OpenAPI schema updates
src/libs/Ultravox/openapi.yaml
Added required property billedMinutes (number, double, "Total billed minutes.") to CallStatistics and DailyCallStatistics schemas.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A nibble of minutes, a billable bite,
I hop through schemas in morning light.
Two stats now tally what calls have spent—
Billed minutes counted, precise and intent.
Thump-thump! says the reviewer’s pen,
Ship it quick—then burrow again.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  - Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.
  - Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch bot/update-openapi_202509081817

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot merged commit d4d6832 into main Sep 8, 2025
3 of 4 checks passed
@github-actions github-actions bot deleted the bot/update-openapi_202509081817 branch September 8, 2025 18:18
@coderabbitai coderabbitai bot changed the title feat:@coderabbitai feat:Add required billedMinutes to CallStatistics and DailyCallStatistics Sep 8, 2025
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/libs/Ultravox/openapi.yaml (1)

3071-3091: Daily billedMinutes: mirror constraints and align naming with BillingUsageDay.minutes

  • Mirror minimum and example here for consistency with CallStatistics.
  • Consider aligning naming with components/schemas/BillingUsageDay.minutes to avoid dual terms for the same concept (can be a follow-up PR).

Apply within this block:

         billedMinutes:
           type: number
-          description: Total billed minutes.
-          format: double
+          description: Total billed minutes for this date. Fractional minutes allowed. Specify rounding/increments.
+          format: double
+          minimum: 0
+          example: 0.75

If keeping both fields, add a brief note in higher-level docs describing the relationship between:

  • UsageResponse.dailyUsage[].minutes
  • CallUsage.daily[].billedMinutes
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0447f6c and 6c622e5.

⛔ Files ignored due to path filters (2)
  • src/libs/Ultravox/Generated/Ultravox.Models.CallStatistics.g.cs is excluded by !**/generated/**
  • src/libs/Ultravox/Generated/Ultravox.Models.DailyCallStatistics.g.cs is excluded by !**/generated/**
📒 Files selected for processing (1)
  • src/libs/Ultravox/openapi.yaml (4 hunks)
🔇 Additional comments (1)
src/libs/Ultravox/openapi.yaml (1)

2938-2957: billedMinutes: enforce non-negative + example + clarify rounding

  • Apply diff:
         billedMinutes:
           type: number
-          description: Total billed minutes.
-          format: double
+          description: Total billed minutes. Fractional minutes allowed; specify billing increments/rounding.
+          format: double
+          minimum: 0
+          example: 12.34
  • Confirm backend always returns this field in every CallStatistics & DailyCallStatistics response; if not, bump API version and document in changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants