-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat:Update OpenAPI for GET /api/voices: provider to providers array #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the OpenAPI spec for GET /api/voices: the query parameter changed from a single string "provider" to an array "providers" of strings, preserving the same allowed values and adjusting descriptions accordingly. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant C as Client
participant API as Ultravox API
participant VS as Voices Service
note over C,API: New behavior: multiple provider filters via providers[]
C->>API: GET /api/voices?providers=google&providers=lmnt
API->>VS: Fetch voices filtered by {google, lmnt}
VS-->>API: Filtered voice list
API-->>C: 200 OK with voices[]
alt Invalid provider value
API-->>C: 400 Bad Request (schema validation)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (1)
🔇 Additional comments (1)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary by CodeRabbit
New Features
Documentation