Skip to content

Add internal serializer for dot snapshot#82

Merged
kamiazya merged 1 commit intomasterfrom
includes-row-serializer
Apr 24, 2020
Merged

Add internal serializer for dot snapshot#82
kamiazya merged 1 commit intomasterfrom
includes-row-serializer

Conversation

@kamiazya
Copy link
Copy Markdown
Member

@kamiazya kamiazya commented Apr 23, 2020

HAS BRAKING CHANGE

What was a problem

When taking a DOT snapshot with the toBeValidDotAndMatchSnapshot API, it was treated as a string and the string was escaped, making the snapshot difficult to read.

How this PR fixes the problem

Created a serializer to avoid escaping strings.

Snapshot Diff

- exports[`public api toBeValidDotAndMatchSnapshot 1`] = `"digraph g { a -> b; }"`;
+ exports[`public api toBeValidDotAndMatchSnapshot 1`] = `digraph g { a -> b; }`;

@kamiazya kamiazya added the enhancement New feature or request label Apr 23, 2020
@kamiazya kamiazya merged commit 5851cc8 into master Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant