Ignore no overload matches error in expectError assertion#33
Merged
Conversation
Collaborator
|
Hi @orta. Thanks for the PR! Could you add an extra test which validates that the error is ignored :)? |
Closed
Contributor
Author
|
No need, there are two tests which include this already 👍 |
SamVerschueren
approved these changes
Sep 16, 2019
Collaborator
|
Cool, totally missed that :)! Thanks for fixing. |
SamVerschueren
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 It looks like TS 3.6 has a new error code which isn't classed as being ignorable in a test, this adds that. As well as providing a bit of error info when that first diagnostics. test fails.
I'm fine with ditching the extra info on the assertion.