Skip to content

Test_pedigree.py with internal samples #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025

Conversation

abureau
Copy link
Contributor

@abureau abureau commented Oct 24, 2024

I have modified TestSimulateThroughPedigree and the simulate_pedigree function to specify generations of subjects as internal samples. Setting internal_sample_gen=[True, False] on line 562 specifies that founders i.e. parents of a two-generation pedigree are samples, but not their children (probands). This results in Fatal Python error: Aborted with core dump in my setup.

@abureau
Copy link
Contributor Author

abureau commented Oct 25, 2024

I continue here the discussion of the closed pull request. I inserted the command
tables.dump("test_shallow_internal.ts")
at line 564 of test_pedigree.py. Then I called
python3 algorithms.py --from-ts test_shallow_internal.ts 4 test.ts
and got no error message. The tree object in the output test.ts seems fine, but I am not sure what to inspect.

No rush to reply, I just report now for later.

@jeromekelleher jeromekelleher added this to the 1.4.0 milestone Jul 23, 2025
Corrections to internal sample tests
@jeromekelleher jeromekelleher marked this pull request as ready for review July 24, 2025 15:20
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.23%. Comparing base (af5bd81) to head (78255b6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2326   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files          20       20           
  Lines       11816    11816           
  Branches     2293     2293           
=======================================
  Hits        10780    10780           
  Misses        568      568           
  Partials      468      468           
Flag Coverage Δ
C 91.23% <ø> (ø)
python 98.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jeromekelleher jeromekelleher merged commit 0c86a4f into tskit-dev:main Jul 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants