-
Notifications
You must be signed in to change notification settings - Fork 77
Add TreeSequence.coiterate(other, **kwargs) method #1021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can pick this one up if you like. Something to do while waiting for rescomp to come back up. Should be easy I think. |
Great, thanks @hyanwong. |
Shall I put it somewhere like |
I think it's a method of TreeSequence: |
Which reminds me, trees.py is getting pretty long now. I wonder if we should split it into |
Feel free to open an issue to gather opinions. |
As discussed in #815, this is a useful operation and should be part of the public API.
The implementation is here, which I think is probably fine. We can leave the door open to coiterating along more than two tree sequences via
*args
, but we don't need to worry about doing it for now.We just need a handful of tests to make sure that (a) this does what we expect on a simple example; (b) the trees are returned in the correct order (i.e.,
tree1.tree_sequence is ts1
) and so on; (c) we test some cases like one ts has one tree and the other has 3, etc; (d) test error conditions are handled correctly.I think we should get this in for 0.3.3
@benjeffery @hyanwong, would one of you mind picking this up please?
The text was updated successfully, but these errors were encountered: