Skip to content

Release 0.5.4? #2672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjeffery opened this issue Jan 4, 2023 · 8 comments
Closed

Release 0.5.4? #2672

benjeffery opened this issue Jan 4, 2023 · 8 comments
Labels
Infrastructure and tools Development infrastructure and tools
Milestone

Comments

@benjeffery
Copy link
Member

It has been a while since the last release (Oct 3), so would be good to put out a release.
I went through the in-flight PRs and added the obvious ones to the 0.5.4 milestone, including Py3.11 support #2248 which I can prioritise.

My other motivation is to get a release out before #2661 (efficient seeking to trees) is merged as that is a large change.

I note that tskit-dev/tutorials#207 is waiting on the new tskit release and should be merged after.

Any objections or PRs I've missed?

@benjeffery benjeffery added the Infrastructure and tools Development infrastructure and tools label Jan 4, 2023
@benjeffery benjeffery added this to the Python 0.5.4 milestone Jan 4, 2023
@hyanwong
Copy link
Member

hyanwong commented Jan 5, 2023

Can we maybe add #2636 which is simply a question of getting the attributions right. Maybe only worth doing if it's easy for you or @jeromekelleher to do (or if I can do it easily).

That way I can fix tskit-dev/tsinfer#753 in tsinfer.

@hyanwong
Copy link
Member

hyanwong commented Jan 6, 2023

The is_empty function was mainly implemented so that we could do something like #2670. I'm ambivalent about whether we want #2670 in 0.5.4, but either way it would be helpful to know if the approach in that PR is the correct one, @benjeffery?

@hyanwong
Copy link
Member

hyanwong commented Jan 7, 2023

Also, might as well merge #2674 (trivial, I think)

@jeromekelleher
Copy link
Member

Good idea. I added in #2663 as well as we should try and get this update for simplify out.

@jeromekelleher
Copy link
Member

(Although I guess that means tagging a C release too - we should look at that separately perhaps)

@hyanwong
Copy link
Member

Are we hoping to get #2607 in too? I think it's just syntactic Python sugar, but it plays nicely with the other simplify additions.

@benjeffery
Copy link
Member Author

Are we hoping to get #2607 in too? I think it's just syntactic Python sugar, but it plays nicely with the other simplify additions.

There's no PR right? I'm tempted to say no as we almost have everything else done.

@jeromekelleher
Copy link
Member

We decided not in #2663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure and tools Development infrastructure and tools
Projects
None yet
Development

No branches or pull requests

3 participants