-
Notifications
You must be signed in to change notification settings - Fork 15
Allow msprime.RateMap or equivalent to be used in pip installs #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any thoughts on the least bad option here @benjeffery ? |
If it's submodule vs copy, I'd go with copy. |
if this is on the cards in the mid-future, that would be the best option. |
We could perhaps put a copy of the |
A better solution might be to move intervals.py into tskit. We will probably be dealing with these tedious issues for getting ratemaps into tskit for LS matching soon, so that might tip the scales. |
Oh yes, it's a great point that we might need something like this for the HMM matching parameters in tskit. Are we happy enough with the FWIW @stsmall was looking to use the |
If it's a clean swap-in then yes, we should probably just move the code straight up into tskit. We can leave the file in msprime until the tskit version is released, and then bump msprime's requirements. |
We can now reactivate this because |
Uh oh!
There was an error while loading. Please reload this page.
In the CLI we use
msprime.RateMap.read_hapmap
to read in a HapMap-format file. But as @jeromekelleher saysThis is annoying because we aren't actually using the C parts of msprime, just the python implementation of RateMap (specifically, the msprime intervals.py file). We should reactivate "--recombination-map" in the CLI support somehow, e.g. by adding that file to the tsinfer repo, either as a copy or using submodules.
The text was updated successfully, but these errors were encountered: