Skip to content

Windows install fails because of msprime #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jeromekelleher opened this issue Oct 24, 2022 · 5 comments
Closed

Windows install fails because of msprime #751

jeromekelleher opened this issue Oct 24, 2022 · 5 comments
Labels
Milestone

Comments

@jeromekelleher
Copy link
Member

We don't have binary wheels for msprime on Windows, and our install is therefore failing on pip (for the reasons that we don't have binary wheels on windows).

This is annoying as we only use msprime to support ratemaps on the command line.

I suggest we remove this feature for 0.3.0 (and the msprime dependency) so that we can get the release out quickly.

@hyanwong, any thoughts?

@jeromekelleher jeromekelleher added this to the Release 0.3.0 milestone Oct 24, 2022
@hyanwong
Copy link
Member

We could remove the --recombination_map option entirely, or just disable it if msprime is not available to import?

@jeromekelleher
Copy link
Member Author

Let's remove the--recombination_map entirely for now. Conditional dependencies are a mess and not what we want to introduce as a quick way of getting the release out.

@hyanwong
Copy link
Member

Disabled in #752. Do we want to leave this issue open or close and open a new one to track getting this in?

In the long term, do we want to

a) port the rate map code into tsinfer (either directly or via e.g. a submodule)
b) have windows wheels
c) move the rate map class into tskit
d) some other solution?

@jeromekelleher
Copy link
Member Author

Let's open a new issue I think. I don't know what the simplest/least bad option is tbh.

hyanwong added a commit to hyanwong/tsinfer that referenced this issue Oct 25, 2022
mergify bot pushed a commit that referenced this issue Oct 25, 2022
@jeromekelleher
Copy link
Member Author

Closed in #752

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants