Skip to content

Temporarily disable --recombination-map in cli #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

hyanwong
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #752 (4f142d2) into main (910e0eb) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
- Coverage   93.50%   93.50%   -0.01%     
==========================================
  Files          17       17              
  Lines        5469     5465       -4     
  Branches     1002     1001       -1     
==========================================
- Hits         5114     5110       -4     
  Misses        234      234              
  Partials      121      121              
Flag Coverage Δ
C 93.50% <ø> (-0.01%) ⬇️
python 96.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tsinfer/cli.py 94.23% <ø> (-0.10%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - should change the issue number to the new issue for adding ratemap support though I'd say.

@jeromekelleher
Copy link
Member

Also need to remove msprime from the install requirements. Fine to leave it in CI/dev requirements.

@hyanwong
Copy link
Member Author

I removed msprime from setup.cfg and changed the issue numbers. I guess this can be merged - CI is complaining about something unrelated.

@mergify mergify bot merged commit fdcbbc4 into tskit-dev:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants