Skip to content

table.simplify() docstring should refer to nodes not individuals #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

hyanwong
Copy link
Member

No idea how this typo managed to sneak in. I hope it wasn't me!

No idea how this typo managed to sneak in. I hope it wasn't me!
@hyanwong hyanwong changed the title Docstring should refer to nodes not individuals table.simplify() docstring should refer to nodes not individuals Feb 18, 2021
Copy link
Member

@jeromekelleher jeromekelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Feb 18, 2021

Codecov Report

Merging #1210 (ae419e1) into main (028997b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1210   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files          26       26           
  Lines       21511    21511           
  Branches      904      904           
=======================================
  Hits        20161    20161           
  Misses       1312     1312           
  Partials       38       38           
Flag Coverage Δ
c-tests 92.50% <ø> (ø)
lwt-tests 92.97% <ø> (ø)
python-c-tests 94.91% <ø> (ø)
python-tests 98.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/tables.py 99.60% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 028997b...ae419e1. Read the comment docs.

@jeromekelleher
Copy link
Member

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2021

Command rebase: success

Branch already up to date

@mergify mergify bot merged commit a23b5b4 into tskit-dev:main Feb 18, 2021
@hyanwong hyanwong deleted the patch-20 branch February 26, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants