Skip to content

Mock out signal.signal for tests. #1217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

jeromekelleher
Copy link
Member

Closes #1216

Hit this problem in msprime recently as well, this is the simplest fix.

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1217 (13c56ed) into main (409361c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1217   +/-   ##
=======================================
  Coverage   93.72%   93.72%           
=======================================
  Files          26       26           
  Lines       21518    21518           
  Branches      906      906           
=======================================
  Hits        20168    20168           
  Misses       1312     1312           
  Partials       38       38           
Flag Coverage Δ
c-tests 92.50% <ø> (ø)
python-c-tests 94.91% <ø> (ø)
python-tests 98.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 409361c...13c56ed. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Feb 24, 2021
@mergify mergify bot merged commit 0a3efe3 into tskit-dev:main Feb 24, 2021
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Feb 24, 2021
@jeromekelleher jeromekelleher deleted the fix-ci-signal branch February 24, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing on OS X python 3.9
2 participants