Skip to content

review #1

@mahuntington

Description

@mahuntington

Good

  • good formatting!
  • you used LESS for CSS! Awesome
  • Angular! YES!

Improvements

  • since you're using LESS, why not take advantage of its nesting abilities. Instead of
div {
    opacity: 1;
}
div.ng-enter {
    -webkit-transition: 1s;
    transition: 1s;
    opacity: 0;
}
...

do this:

div {
    opacity: 1;
    &.ng-enter {
        -webkit-transition: 1s;
        transition: 1s;
        opacity: 0;
    }
}
...
  • you put a lot of stuff on $scope. This is fine, but consider putting it on this. That way $scope doesn't get all cluttered up. Just a thought.
  • clean up commented out code
  • you can use indexOf instead of $.inArray http://www.w3schools.com/jsref/jsref_indexof_array.asp
  • ignore your dist directory
  • if can, try to avoid using jQuery and Angular. It's just a lot of library code, and, almost all the time, you can get away with just one.
  • what does a.js do?
  • maybe some cleaner styling? Get a designer to help you out.

Overall
You pulled off an angular site really well, considering how little we touched it. Hope you enjoyed doing that. Nice work!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions